Address more comments

Author: justing-bq

cpp/src/arrow/flight/sql/odbc/odbc_impl/flight_sql_result_set_metadata.cc

@@ -20,6 +20,7 @@
 #include "arrow/flight/sql/column_metadata.h"
 #include "arrow/flight/sql/odbc/odbc_impl/platform.h"
 #include "arrow/flight/sql/odbc/odbc_impl/util.h"
+#include "arrow/type_traits.h"
 #include "arrow/util/key_value_metadata.h"
 
 #include <utility>
@@ -204,7 +205,8 @@ size_t FlightSqlResultSetMetadata::GetOctetLength(int column_position) {
       .value_or(DefaultLengthForVariableLengthColumns);
 }
 
-std::string FlightSqlResultSetMetadata::GetTypeName(int column_position, int data_type) {
+std::string FlightSqlResultSetMetadata::GetTypeName(int column_position,
+                                                    int16_t data_type) {
   ColumnMetadata metadata = GetMetadata(schema_->field(column_position - 1));
 
   return metadata.GetTypeName().ValueOrElse([data_type] {
@@ -240,26 +242,7 @@ Searchability FlightSqlResultSetMetadata::IsSearchable(int column_position) {
 bool FlightSqlResultSetMetadata::IsUnsigned(int column_position) {
   const std::shared_ptr<Field>& field = schema_->field(column_position - 1);
 
-  switch (field->type()->id()) {
-    case Type::INT8:
-    case Type::INT16:
-    case Type::INT32:
-    case Type::INT64:
-    case Type::DOUBLE:
-    case Type::FLOAT:
-    case Type::HALF_FLOAT:
-    case Type::DECIMAL32:
-    case Type::DECIMAL64:
-    case Type::DECIMAL128:
-    case Type::DECIMAL256:
-      return false;
-    case Type::UINT8:
-    case Type::UINT16:
-    case Type::UINT32:
-    case Type::UINT64:
-    default:
-      return true;
-  }
+  return arrow::is_unsigned_integer(field->type()->id());
 }
 
 bool FlightSqlResultSetMetadata::IsFixedPrecScale(int column_position) {

cpp/src/arrow/flight/sql/odbc/odbc_impl/flight_sql_result_set_metadata.h

@@ -77,7 +77,7 @@ class FlightSqlResultSetMetadata : public ResultSetMetadata {
 
   size_t GetOctetLength(int column_position) override;
 
-  std::string GetTypeName(int column_position, int data_type) override;
+  std::string GetTypeName(int column_position, int16_t data_type) override;
 
   Updatability GetUpdatable(int column_position) override;
 

cpp/src/arrow/flight/sql/odbc/odbc_impl/spi/result_set_metadata.h

@@ -144,7 +144,7 @@ class ResultSetMetadata {
   /// \param column_position [in] the position of the column, starting from 1.
   /// \param data_type [in] the data type of the column.
   /// \return the data type string.
-  virtual std::string GetTypeName(int column_position, int data_type) = 0;
+  virtual std::string GetTypeName(int column_position, int16_t data_type) = 0;
 
   /// \brief It returns a numeric values indicate the updatability of the
   /// column.