Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-44223: [Dev] Use "Gandiva" instead of "C++ - Gandiva" label #44722

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

kou
Copy link
Member

@kou kou commented Nov 14, 2024

Rationale for this change

We have Gandiva related codes. So "C++ -" isn't match the current code base.

What changes are included in this PR?

Remove the "C++ - " part.

Are these changes tested?

No.

Are there any user-facing changes?

No.

Copy link

⚠️ GitHub issue #44223 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Nov 14, 2024
Copy link
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, do we also have to create the label manually here: https://github.com/apache/arrow/labels ?

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Nov 14, 2024
@kou
Copy link
Member Author

kou commented Nov 14, 2024

Ah, can we rename the existing "C++ - Gandiva" label to "Gandiva"?

@raulcd
Copy link
Member

raulcd commented Nov 14, 2024

Ah, can we rename the existing "C++ - Gandiva" label to "Gandiva"?

Yes, I am going to rename the label and merge this.

@raulcd raulcd merged commit 26aa75f into apache:main Nov 14, 2024
6 checks passed
@raulcd raulcd removed the awaiting merge Awaiting merge label Nov 14, 2024
@raulcd
Copy link
Member

raulcd commented Nov 14, 2024

I've renamed the label: Component: Gandiva

@kou kou deleted the dev-label-gandiva branch November 14, 2024 11:43
@kou
Copy link
Member Author

kou commented Nov 14, 2024

Thanks!

Copy link

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 26aa75f.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants