Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] Update bundled AWS SDK for C++ from 1.10.55 #45195

Open
Tracked by #45303
kou opened this issue Jan 7, 2025 · 9 comments
Open
Tracked by #45303

[C++] Update bundled AWS SDK for C++ from 1.10.55 #45195

kou opened this issue Jan 7, 2025 · 9 comments

Comments

@kou
Copy link
Member

kou commented Jan 7, 2025

Describe the enhancement requested

The current bundled version is 1.10.55:

ARROW_AWSSDK_BUILD_VERSION=1.10.55

The latest version is 1.11.480 now: https://github.com/aws/aws-sdk-cpp/tags

This will help #44989 too.

Component(s)

C++

@kou kou changed the title [C++] Update bundled AWS SDK for C++ [C++] Update bundled AWS SDK for C++ from 1.10.55 Jan 7, 2025
@amoeba amoeba self-assigned this Jan 8, 2025
@amoeba
Copy link
Member

amoeba commented Jan 8, 2025

Changing just the version and checksum to match 1.11.480, I'm running into some configure issues in the aws-sdk-cpp EP:

CMake Error at cmake/sdks.cmake:167 (message):
  config is required for build, but generated/src/aws-cpp-sdk-config
  directory is missing!

The entire generated directory is being wiped out inside the EP and we want to keep around the ones we reference here,

  set(AWSSDK_CMAKE_ARGS
      ${AWSSDK_COMMON_CMAKE_ARGS}
      -DBUILD_DEPS=OFF
      -DBUILD_ONLY=config\\$<SEMICOLON>s3\\$<SEMICOLON>transfer\\$<SEMICOLON>identity-management\\$<SEMICOLON>sts
      -DMINIMIZE_SIZE=ON)

I imagine we're just missing the right configure args to keep those around.

@kou
Copy link
Member Author

kou commented Jan 8, 2025

I think that we should use FetchContent instead of ExternalProject_Add() for this. We can't maintain AWS SDK for C++ related dependencies manually...

@amoeba
Copy link
Member

amoeba commented Jan 8, 2025

Okay. I might not get to creating a PR for this right away so I'm going to de-assign myself. Maybe @assignUser would want to take this on?

@amoeba amoeba removed their assignment Jan 8, 2025
@kou
Copy link
Member Author

kou commented Jan 8, 2025

Or I may work on this after apache/arrow-java#20.

@h-vetinari
Copy link
Contributor

h-vetinari commented Jan 20, 2025

Something broke between 1.11.458 and 1.11.488, I recommend not going past 1.11.458 until we understand this better (or we debug it conclusively and then fix it).

@amoeba
Copy link
Member

amoeba commented Jan 21, 2025

Thanks for the note @h-vetinari. From the looks of it, there should be a fixed release of aws-sdk-cpp soon we can jump to if we like.

@h-vetinari
Copy link
Contributor

Indeed, 1.11.489 should be fine again (but it'll be a little while yet before we test it in conda-forge)

@eschneeweiss
Copy link

Hi everybody! I don't know I'm new to pyarrow, but the python library ray uses pyarrow under the hood. And I have recently run into an issue with uesing pyarrow to get credentials in an EKS cluster using eks-pod-identity-agent.

The issue seems to be with the AWS SDK for c++. AWS says the minimum version should be 1.11.263 . So updating the version here would be greatly appreciated!

@kou
Copy link
Member Author

kou commented Mar 11, 2025

The current status: #45306 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants