Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to include README in jar #7

Open
stevedlawrence opened this issue Jan 23, 2024 · 6 comments
Open

Option to include README in jar #7

stevedlawrence opened this issue Jan 23, 2024 · 6 comments

Comments

@stevedlawrence
Copy link
Member

Since we often distribute schemas as jars, it would be useful to include the README as well, since this file usually includes helpful things like usage and license information, which isn't necessarily in the schema files.

@stevedlawrence
Copy link
Member Author

We should also include LICENSE/NOTICE files if they exist.

@olabusayoT
Copy link

I wonder if we can also add build.sbt, since all of our schema projects rely on it.

@stevedlawrence
Copy link
Member Author

Possibly, though the layout of a jar is different than an SBT project. For example, it does not have a src/main/resources directory. So it isn't necessarily as simple as unziping a jar and running sbt, my guess is that isn't going to work. Note that we would also need to include plugins.bt since many build.sbt files rely on multiple plugins. More thought is probably needed to figure out how convert a jar to a buildable SBT project, or if another approach is needed (i.e. deliver the source repo with certain source/test files removed if necessary).

@mbeckerle
Copy link

If one adds a src/main/resources/doc directory with files in it, are those going to end up in a doc subdir in the jar, or does some special provision need to be made to get that to happen?

@stevedlawrence
Copy link
Member Author

Yep, anything in src/main/resources ends up in the root of the jar, including any subdirectories. Nothing special needs to be done.

@mbeckerle
Copy link

So perhaps all we need is guidelines that the README.md is for us, and user doc, rel-notes, instructions, whatever we want to include is just referenced from the README but lives under src/main/resources/doc ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants