Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use unified memory management for Comet all the times #1017

Closed
viirya opened this issue Oct 12, 2024 · 0 comments · Fixed by #1062
Closed

Use unified memory management for Comet all the times #1017

viirya opened this issue Oct 12, 2024 · 0 comments · Fixed by #1062
Assignees
Labels
enhancement New feature or request

Comments

@viirya
Copy link
Member

viirya commented Oct 12, 2024

What is the problem the feature request solves?

We currently only enable unified memory manager for Comet if off-heap mode is enabled. It causes some memory issues like #996, #949, etc.

Re-thinking about this, I think a better approach is to always use unified memory management for Comet, i.e. off-heap mode must be enabled for Comet. It could simplify memory management in Comet. It can give a more explicit signal to users that off-heap memory is used for Comet native execution that should give users a more clear picture about how Spark/Comet memory is used (so they don't need to guess).

Describe the potential solution

No response

Additional context

No response

@viirya viirya added the enhancement New feature or request label Oct 12, 2024
@viirya viirya self-assigned this Oct 12, 2024
@viirya viirya changed the title Use unified memory management for Comet Use unified memory management for Comet all the times Oct 12, 2024
@andygrove andygrove self-assigned this Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants