feat: Require offHeap memory to be enabled (always use unified memory) #1062
+16
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
changed the title
|
Is #875 a blocker for this PR |
I don't think so. I have been using the unified memory approach for my local benchmarking and have not encountered any issues. |
|
All tests are passing, but this is misleading because the Spark tests are running with |
|
Oh, I misread it. |
|
Yea, we can try to restore it in #1063. As I commented there, if Spark tests cannot pass under off-heap, we can have a test-only setup to run Spark tests with on-heap + Comet execution. |
viirya
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #949
Closes #1017
Rationale for this change
What changes are included in this PR?
How are these changes tested?