Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stddev_pop not compatible with Spark in some cases #1375

Closed
andygrove opened this issue Feb 6, 2025 · 1 comment
Closed

stddev_pop not compatible with Spark in some cases #1375

andygrove opened this issue Feb 6, 2025 · 1 comment
Labels
bug Something isn't working
Milestone
0.7.0

Comments

@andygrove
Copy link
Member

Describe the bug

I am working on adding fuzz testing to the test suite in PR #1374 and it appears that stddev_pop produces incorrect results in some cases

SELECT c1, stddev_pop(c5) FROM t1 GROUP BY c1 ORDER BY c1

1.888946593147858E22 was not less than 1.0E-6 actual answer 1.2417965031048596E38

Steps to reproduce

No response

Expected behavior

No response

Additional context

No response
@andygrove andygrove added the bug Something isn't working label Feb 6, 2025
@andygrove andygrove added this to the 0.7.0 milestone Feb 6, 2025
@andygrove
Copy link
Member Author

Actually, it looks like the code for checking answers allowing for tolerance may not be correct:

The expected vs actual are:

1.2417965031048596E38
1.2417965031048598E38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.7.0
Development

No branches or pull requests
1 participant
@andygrove