Overflow happened on: -2147483648 % -1

[wForget]

Describe the bug

-2147483648 % -1 evaluates to 0 in scala, but fails in rust.

scala:

rust:

Steps to reproduce

reproduce with spark sql:

  test("Overflow happened on: -2147483648 % -1") {
    withTable("t1") {
      sql("create table t1(c1 int, c2 short) using parquet")
      sql("insert into t1 values(-2147483648, -1)")
      checkSparkAnswerAndOperator("select c1 % c2 from t1")
    }
  }

Expected behavior

No response

Additional context

No response

[andygrove]

Nice find. Thanks @wForget. Do you plan on working on a fix?

[wForget]

Nice find. Thanks @wForget. Do you plan on working on a fix?

I will try to fix it.

[kazuyukitanimura]

It looks addition is working, I wonder what would be the difference

checkSparkAnswerAndOperator("select c1 + c2 from t1")

[parthchandra]

Info on rust integer overflow: https://github.com/rust-lang/rfcs/blob/master/text/0560-integer-overflow.md

The operations +, -, *, can underflow and overflow. When checking is enabled this will panic. When checking is disabled this will two's complement wrap.
The operations /, % for the arguments INT_MIN and -1 will unconditionally panic. This is unconditional for legacy reasons.
Shift operations (<<, >>) on a value of width N can be passed a shift value >= N. It is unclear what behaviour should result from this, so the shift value is unconditionally masked to be modulo N to ensure that the argument is always in range.