feat: Support IntegralDivide function #1428
Open
+30
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1428 +/- ##
============================================
+ Coverage 56.12% 57.81% +1.68%
- Complexity 976 983 +7
============================================
Files 119 122 +3
Lines 11743 12121 +378
Branches 2251 2282 +31
============================================
+ Hits 6591 7008 +417
+ Misses 4012 3943 -69
- Partials 1140 1170 +30 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1422.
Rationale for this change
Support IntegralDivide function
What changes are included in this PR?
Since datafusion div operator conforms to the logic of intergal div, we only need to convert
IntegralDivide(...)toCast(Divide(...), LongType)and then convert it to native.How are these changes tested?
added unit test