Skip to content

Improve SessionContext::parse_duration API #20815

@erenavsarogullari

Description

@erenavsarogullari

Is your feature request related to a problem or challenge?

This is follow-up issue for #20371.

Similarly to SessionContext::parse_capacity_limit API, SessionContext::parse_duration API also needs to have following improvements:

  1. Validation for empty or blank duration values:
SET datafusion.runtime.list_files_cache_ttl = ' '

Current:
DataFusion error: Error during planning: Failed to parse number from duration ' '

New:
DataFusion error: Error during planning: Duration should not be empty or blank for 'datafusion.runtime.list_files_cache_ttl'
  1. Exposing config name in error messages,
  2. Comprehensive test coverage for invalid durations,
  3. Updating datafusion.runtime.list_files_cache_ttl documentation for other allowed settings.

Describe the solution you'd like

Explained by first section.

Describe alternatives you've considered

No response

Additional context

No response

Metadata

Metadata

Labels

enhancementNew feature or request

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions