Skip to content

Remove unstable public methods for DynamicFilterPhysicalExpr after proto migration #23422

Description

@jayshrivastava

Is your feature request related to a problem or challenge?

See #22418. After migrating DynamicFilterPhysicalExpr serialization from relying on leaking public internals, we can now remove these unstable methods because they aren't used outside the package.

pub struct Inner {
...
}

/// Return the filter's original children (before any remapping).
///
/// **Warning:** intended only for `datafusion-proto` (de)serialization.
/// Not a stable API.
pub fn original_children(&self) -> &[Arc<dyn PhysicalExpr>] {
    &self.children
}

/// Return the filter's remapped children, if any have been set via
/// [`PhysicalExpr::with_new_children`].
///
/// **Warning:** intended only for `datafusion-proto` (de)serialization.
/// Not a stable API.
pub fn remapped_children(&self) -> Option<&[Arc<dyn PhysicalExpr>]> {
    self.remapped_children.as_deref()
}

Describe the solution you'd like

No response

Describe alternatives you've considered

No response

Additional context

No response

Metadata

Metadata

Labels

enhancementNew feature or request

Fields

No fields configured for Feature.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions