Skip to content

Conversation

@vegarsti
Copy link
Contributor

@vegarsti vegarsti commented Nov 9, 2025

Which issue does this PR close?

Closes #18516, although it does still not allow for doing SELECT * WHERE ree_encoded_column_name = 'test' because we don't have the necessary cast support available yet. See the issue for more details.

What changes are included in this PR?

Type coercion logic for RunEndEncoded types to datafusion-expr-common. I've basically tried to copy what's done for dictionaries. It's quite possible I missed something!

Are these changes tested?

Yes, adds new tests for type coercion of REE types to datafusion-expr-common.

@github-actions github-actions bot added the logical-expr Logical plan and expressions label Nov 9, 2025
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vegarsti -- this looks good to me

Copy link
Member

@Weijun-H Weijun-H left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @vegarsti 👍

@Weijun-H Weijun-H added this pull request to the merge queue Nov 11, 2025
Merged via the queue into apache:main with commit cb1f019 Nov 11, 2025
35 of 37 checks passed
@Weijun-H
Copy link
Member

Thanks @alamb for reviewing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

logical-expr Logical plan and expressions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

REE type coercion not working correctly

3 participants