[Feat](nereids) support ShowTabletStorageFormat command in nereids #43295
+151
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
rijeshkp
force-pushed
the
ShowTableStorageFormatToNereids
branch
from
a1fb1da
to
f3729c0
Compare
|
run buildall |
TPC-H: Total hot run time: 41191 ms |
TPC-DS: Total hot run time: 197783 ms |
starocean999
reviewed
Nov 6, 2024
| if (result == null) { | ||
| throw new AnalysisException("get tablet data from backend: " + be.getId() + "error."); | ||
| } | ||
| if (isVerbose()) { |
There was a problem hiding this comment.
remove isVerbose() function, access verbose member directly
starocean999
reviewed
Nov 6, 2024
| @Override | ||
| public void run(ConnectContext ctx, StmtExecutor executor) throws Exception { | ||
| if (!Env.getCurrentEnv().getAccessManager().checkGlobalPriv(ConnectContext.get(), PrivPredicate.ADMIN) | ||
| && !Env.getCurrentEnv().getAccessManager().checkGlobalPriv(ConnectContext.get(), |
There was a problem hiding this comment.
!Env.getCurrentEnv().getAccessManager().checkGlobalPriv(ConnectContext.get(), PrivPredicate.OPERATOR) is not in ShowTabletStorageFormatStmt's analyze() method, why need it here?
There was a problem hiding this comment.
Removed the check. Thanks for pointing it out. Since this is admin only, the operator should not be allowed.
starocean999
reviewed
Nov 6, 2024
| /** | ||
| * admin show tablet storage format command | ||
| */ | ||
| public class ShowTabletStorageFormatCommand extends Command implements NoForward { |
There was a problem hiding this comment.
a new method checkSupportedInCloudMode() is added in Command.java by https://github.com/apache/doris/pull/43271/files, ShowTabletStorageFormatCommand need implement it with same logic like ShowTabletStorageFormatStmt, please update after the pr is merged
There was a problem hiding this comment.
Sure. Update after the PR is merged.
starocean999
changed the title
starocean999
reviewed
Nov 6, 2024
| */ | ||
| public class ShowTabletStorageFormatCommand extends Command implements NoForward { | ||
| public static final Logger LOG = LogManager.getLogger(ShowTabletStorageFormatCommand.class); | ||
| private boolean verbose; |
There was a problem hiding this comment.
Suggested change
| private boolean verbose; | |
| private final boolean verbose; |
rijeshkp
force-pushed
the
ShowTableStorageFormatToNereids
branch
from
c36ee4b
to
53323be
Compare
|
run buildall |
|
Output Screenshot
|
TPC-H: Total hot run time: 41189 ms |
TPC-DS: Total hot run time: 196541 ms |
ClickBench: Total hot run time: 32.84 s |
|
pr's related issue is |
|
please rebase latest master and resolve the conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #42783
Related PR: #xxx
Problem Summary:
Check List (For Committer)
Test
Behavior changed:
Does this need documentation?
Release note
None
Check List (For Reviewer who merge this PR)