Skip to content

Navigation Menu

Explore
By company size
By use case
By industry
View all solutions
Topics
- AI
- DevOps
- Security
- Software Development
- View all
Explore
- GitHub Sponsors
  Fund open source developers
- The ReadME Project
  GitHub community articles
Repositories
- Enterprise platform
  AI-powered developer platform
Available add-ons
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

apache / doris Public

Notifications You must be signed in to change notification settings
Fork 3.3k
Star 12.7k

Code
Issues 2.6k
Pull requests 544
Discussions
Actions
Projects 3
Wiki
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Discussions
Actions
Projects
Wiki
Security
Insights

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat](Nereids) support refresh catalog command #43449

Open

vinlee19 wants to merge 15 commits into apache:master

base: master

Choose a base branch

Loading

Loading

from vinlee19:nereids_refresh_catalog

Open

[feat](Nereids) support refresh catalog command #43449

vinlee19 wants to merge 15 commits into apache:master from vinlee19:nereids_refresh_catalog

+289 −5

Conversation 20 Commits 15 Checks 6 Files changed 9

Conversation

Copy link

Contributor

vinlee19 commented Nov 7, 2024 •

edited

Loading

What problem does this PR solve?

Issue Number: close # #42580

Related PR: #xxx

Problem Summary:
support refresh catalog command in Nereids

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No colde files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes.
Release note

None

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

Sorry, something went wrong.

All reactions

vinlee19 and others added 3 commits

November 5, 2024 19:29


          support refresh catalog command

b17397f


          add logic plan builder

741b486

fix null pointer

add process logic

modify refresh manager logic

modify refresh manager logic


          Optimized the refresh command to operate without requiring properties…

5b3f28a

… and included a regression test.

Copy link

doris-robot commented Nov 7, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes.
Release note

None

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

All reactions

Sorry, something went wrong.

vinlee19 and others added 9 commits

November 8, 2024 10:35


          Merge branch 'master' into nereids_refresh_catalog

574dbc0


          resolve conflict

ba4d29a


          resolve conflict

c6a037f


          resolve conflict

c1258ae


          resolve conflict

299178f


          resolve conflict

cd42fcc


          optimize code

321564d


          optimize code style

ba2e7f8


          optimize regression test case

49be245

Copy link

Contributor Author

vinlee19 commented Nov 8, 2024

run buildall

All reactions

Sorry, something went wrong.

Copy link

Collaborator

LiBinfeng-01 commented Nov 8, 2024

LGTM

All reactions

Sorry, something went wrong.

LiBinfeng-01 approved these changes

View reviewed changes

fe/fe-core/src/main/java/org/apache/doris/nereids/parser/LogicalPlanBuilder.java Outdated Show resolved Hide resolved

...c/main/java/org/apache/doris/nereids/trees/plans/commands/refresh/RefreshCatalogCommand.java Outdated Show resolved Hide resolved

fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/visitor/CommandVisitor.java Outdated Show resolved Hide resolved

regression-test/suites/external_table_p0/nereids_commands/test_nereids_refresh_catalog.groovy Outdated Show resolved Hide resolved

regression-test/suites/external_table_p0/nereids_commands/test_nereids_refresh_catalog.groovy Outdated Show resolved Hide resolved

regression-test/suites/external_table_p0/nereids_commands/test_nereids_refresh_catalog.groovy Outdated Show resolved Hide resolved

Copy link

Contributor

github-actions bot commented Nov 8, 2024

PR approved by anyone and no changes requested.

All reactions

Sorry, something went wrong.

github-actions bot added the reviewed label

starocean999 reviewed

View reviewed changes

fe/fe-core/src/main/java/org/apache/doris/nereids/parser/LogicalPlanBuilder.java Outdated Show resolved Hide resolved

starocean999 reviewed

View reviewed changes

...c/main/java/org/apache/doris/nereids/trees/plans/commands/refresh/RefreshCatalogCommand.java Outdated Show resolved Hide resolved

starocean999 reviewed

View reviewed changes

...c/main/java/org/apache/doris/nereids/trees/plans/commands/refresh/RefreshCatalogCommand.java Outdated Show resolved Hide resolved

starocean999 reviewed

View reviewed changes

...c/main/java/org/apache/doris/nereids/trees/plans/commands/refresh/RefreshCatalogCommand.java Outdated Show resolved Hide resolved

starocean999 reviewed

View reviewed changes

...c/main/java/org/apache/doris/nereids/trees/plans/commands/refresh/RefreshCatalogCommand.java Outdated Show resolved Hide resolved


          remove useless method

Copy link

Contributor Author

vinlee19 commented Nov 8, 2024

run buildall

All reactions

Sorry, something went wrong.


          Merge branch 'master' into nereids_refresh_catalog

8deae3f

Copy link

Contributor Author

vinlee19 commented Nov 14, 2024

run buildall

All reactions

Sorry, something went wrong.

Copy link

Contributor

starocean999 commented Nov 15, 2024

please resolve the conflicts

All reactions

Sorry, something went wrong.


          Merge branch 'master' into nereids_refresh_catalog

Copy link

Contributor Author

vinlee19 commented Nov 15, 2024

run buildall

All reactions

Sorry, something went wrong.

Copy link

Contributor Author

vinlee19 commented Nov 15, 2024

@morningman PTAL

All reactions

Sorry, something went wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

starocean999 starocean999 left review comments

LiBinfeng-01 LiBinfeng-01 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.

Footer

© 2024 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Docs
Contact

You can’t perform that action at this time.