Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] NetUtils should ignore the local link address #14792

Open
4 tasks done
cyclinder opened this issue Oct 18, 2024 · 2 comments · May be fixed by #14793
Open
4 tasks done

[Bug] NetUtils should ignore the local link address #14792

cyclinder opened this issue Oct 18, 2024 · 2 comments · May be fixed by #14793
Assignees
Labels
component/need-triage Need maintainers to triage type/need-triage Need maintainers to triage

Comments

@cyclinder
Copy link

Pre-check

  • I am sure that all the content I provide is in English.

Search before asking

  • I had searched in the issues and found no similar issues.

Apache Dubbo Component

Java SDK (apache/dubbo)

Dubbo Version

Any

Steps to reproduce this issue

In the K8S scenario, some applications may have two NICs, eth0 and veth0, and eth0 is configured with a real physical address. veth0 is configured with a local link address, which may randomly select the local link address to veth0, resulting in unavailability of the service.

When I look at the netUtils code, I see that netutils only ignores the lookback address, not the local link address.

https://github.com/mercyblitz/dubbo/blob/d8a4acd13c8270bdefe38f8b109dee457ee15593/dubbo-common/src/main/java/org/apache/dubbo/common/utils/NetUtils.java#L148

What you expected to happen

NetUtils should ignore the local link address

Anything else

No response

Are you willing to submit a pull request to fix on your own?

  • Yes I am willing to submit a pull request on my own!

Code of Conduct

@cyclinder cyclinder added component/need-triage Need maintainers to triage type/need-triage Need maintainers to triage labels Oct 18, 2024
@wcy666103
Copy link
Contributor

You can submit a pr to try and fix the issue.

@cyclinder cyclinder linked a pull request Oct 18, 2024 that will close this issue
4 tasks
@cyclinder
Copy link
Author

I've opened #14793 to fix this, please take a review in your free time, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/need-triage Need maintainers to triage type/need-triage Need maintainers to triage
Projects
Status: Todo
Development

Successfully merging a pull request may close this issue.

2 participants