FINERACT-5706: Add unit tests for MathUtil

Signed-off-by: Shlesha <shlesha04@gmail.com>

Author: shleshaG

fineract-core/src/test/java/org/apache/fineract/infrastructure/core/service/IpAddressUtilsTest.java

@@ -1,21 +1,3 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied. See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
 package org.apache.fineract.infrastructure.core.service;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
@@ -34,14 +16,14 @@ void clearContext() {
         RequestContextHolder.resetRequestAttributes();
     }
 
-    // Proper isolation helper
+    // Helper method for setting request context
     private void withRequest(HttpServletRequest request, Runnable testLogic) {
         ServletRequestAttributes attributes = new ServletRequestAttributes(request);
         try {
             RequestContextHolder.setRequestAttributes(attributes);
             testLogic.run();
         } finally {
-            RequestContextHolder.resetRequestAttributes(); // critical cleanup
+            RequestContextHolder.resetRequestAttributes();
         }
     }
 
@@ -86,4 +68,4 @@ void getClientIpConvertsNonStringAttributeUsingToString() {
             assertEquals("12345", result);
         });
     }
-}
+}

fineract-core/src/test/java/org/apache/fineract/infrastructure/core/service/MathUtilTest.java

@@ -39,16 +39,41 @@ void nullToDefaultReturnsValueWhenNotNull() {
         assertEquals(10L, MathUtil.nullToDefault(10L, 5L));
     }
 
+    @Test
+    void nullToDefaultHandlesNegativeValues() {
+        assertEquals(-5, MathUtil.nullToDefault(-5, 10));
+    }
+
     @Test
     void nullToZeroLongReturnsZeroWhenNull() {
         assertEquals(0L, MathUtil.nullToZero((Long) null));
     }
 
+    @Test
+    void nullToZeroLongReturnsValueWhenNotNull() {
+        assertEquals(10L, MathUtil.nullToZero(10L));
+    }
+
+    @Test
+    void nullToZeroIntegerReturnsZeroWhenNull() {
+        assertEquals(0, MathUtil.nullToZero((Integer) null));
+    }
+
+    @Test
+    void nullToZeroIntegerReturnsValueWhenNotNull() {
+        assertEquals(7, MathUtil.nullToZero(7));
+    }
+
     @Test
     void zeroToNullReturnsNullWhenZero() {
         assertNull(MathUtil.zeroToNull(0L));
     }
 
+    @Test
+    void zeroToNullReturnsValueWhenNonZero() {
+        assertEquals(5L, MathUtil.zeroToNull(5L));
+    }
+
     @Test
     void negativeToZeroReturnsZeroForNegativeValue() {
         assertEquals(0L, MathUtil.negativeToZero(-10L));
@@ -79,37 +104,68 @@ void addReturnsSumOfValues() {
         assertEquals(30L, MathUtil.add(10L, 20L));
     }
 
+    @Test
+    void addMultipleValuesWorks() {
+        assertEquals(60L, MathUtil.add(10L, 20L, 30L));
+    }
+
     @Test
     void subtractReturnsCorrectDifference() {
         assertEquals(15L, MathUtil.subtract(20L, 5L));
     }
 
+    @Test
+    void subtractHandlesNullSecond() {
+        assertEquals(10L, MathUtil.subtract(10L, (Long) null));
+    }
+
+    @Test
+    void subtractToZeroNeverNegative() {
+        assertEquals(0L, MathUtil.subtractToZero(10L, 20L));
+    }
+
     @Test
     void absReturnsPositiveValue() {
         assertEquals(25L, MathUtil.abs(-25L));
     }
 
     @Test
     void bigDecimalAddReturnsCorrectSum() {
-        BigDecimal result = MathUtil.add(new BigDecimal("10.5"), new BigDecimal("5.5"), new MathContext(10));
+        BigDecimal result = MathUtil.add(
+                new BigDecimal("10.5"),
+                new BigDecimal("5.5"),
+                new MathContext(10)
+        );
         assertEquals(0, result.compareTo(new BigDecimal("16.0")));
     }
 
     @Test
     void bigDecimalSubtractReturnsCorrectDifference() {
-        BigDecimal result = MathUtil.subtract(new BigDecimal("20"), new BigDecimal("5"), new MathContext(10));
+        BigDecimal result = MathUtil.subtract(
+                new BigDecimal("20"),
+                new BigDecimal("5"),
+                new MathContext(10)
+        );
         assertEquals(0, result.compareTo(new BigDecimal("15")));
     }
 
     @Test
     void percentageOfCalculatesCorrectValue() {
-        BigDecimal result = MathUtil.percentageOf(new BigDecimal("200"), new BigDecimal("10"), new MathContext(10));
+        BigDecimal result = MathUtil.percentageOf(
+                new BigDecimal("200"),
+                new BigDecimal("10"),
+                new MathContext(10)
+        );
         assertEquals(0, result.compareTo(new BigDecimal("20")));
     }
 
     @Test
     void percentageOfReturnsZeroWhenValueZero() {
-        BigDecimal result = MathUtil.percentageOf(BigDecimal.ZERO, new BigDecimal("10"), new MathContext(10));
+        BigDecimal result = MathUtil.percentageOf(
+                BigDecimal.ZERO,
+                new BigDecimal("10"),
+                new MathContext(10)
+        );
         assertEquals(0, result.compareTo(BigDecimal.ZERO));
     }
 
@@ -123,19 +179,4 @@ void stripTrailingZerosRemovesExtraZeros() {
     void stripTrailingZerosReturnsNullWhenInputNull() {
         assertNull(MathUtil.stripTrailingZeros(null));
     }
-
-    @Test
-    void subtractHandlesNullSecond() {
-        assertEquals(10L, MathUtil.subtract(10L, (Long) null));
-    }
-
-    @Test
-    void addMultipleValuesWorks() {
-        assertEquals(60L, MathUtil.add(10L, 20L, 30L));
-    }
-
-    @Test
-    void subtractToZeroNeverNegative() {
-        assertEquals(0L, MathUtil.subtractToZero(10L, 20L));
-    }
-}
+}