[Improvement] Create supporting index on iceberg_tables for PostgreSQL JDBC catalogs at scale #21340
trino-integration-test.yml
on: pull_request
changes
10s
Matrix: TrinoIT
Annotations
2 errors and 4 warnings
|
TrinoIT (linux/amd64, 17)
Process completed with exit code 1.
|
|
TrinoIT (linux/amd64, 17):
task ':iceberg:iceberg-common:spotlessJavaCheck'#L0
Execution failed for task ':iceberg:iceberg-common:spotlessJavaCheck':
The following files had format violations:
src/main/java/org/apache/iceberg/jdbc/JdbcCatalogWithMetadataLocationSupport.java
@@ -46,8 +46,7 @@
···*·Name·of·the·supporting·index·created·on·{@value·JdbcUtil#CATALOG_TABLE_VIEW_NAME}·for
···*·PostgreSQL·backends.·See·{@link·#maybeCreateNamespaceIndex(Map)}·for·why·it's·needed.
···*/
-··private·static·final·String·NAMESPACE_INDEX_NAME·=
-······"gravitino_iceberg_tables_namespace_pattern";
+··private·static·final·String·NAMESPACE_INDEX_NAME·=·"gravitino_iceberg_tables_namespace_pattern";
··private·static·final·String·POSTGRESQL_PRODUCT_NAME·=·"PostgreSQL";
src/test/java/org/apache/iceberg/jdbc/TestJdbcCatalogWithMetadataLocationSupportNamespaceIndex.java
@@ -62,8 +62,7 @@
··@test
··void·testIndexCreatedByDefault()·throws·Exception·{
-····String·jdbcUrl·=
-········postgreSQLContainer.getJdbcUrl(TestDatabaseName.PG_ICEBERG_NAMESPACE_INDEX_IT);
+····String·jdbcUrl·=·postgreSQLContainer.getJdbcUrl(TestDatabaseName.PG_ICEBERG_NAMESPACE_INDEX_IT);
····JdbcCatalogWithMetadataLocationSupport·catalog·=
········new·JdbcCatalogWithMetadataLocationSupport(true);
@@ -75,8 +74,7 @@
··@test
··void·testIndexCreationCanBeDisabled()·throws·Exception·{
-····String·jdbcUrl·=
-········postgreSQLContainer.getJdbcUrl(TestDatabaseName.PG_ICEBERG_NAMESPACE_INDEX_IT);
+····String·jdbcUrl·=·postgreSQLContainer.getJdbcUrl(TestDatabaseName.PG_ICEBERG_NAMESPACE_INDEX_IT);
····Map<String,·String>·properties·=·newProperties(jdbcUrl);
····properties.put(IcebergConstants.ICEBERG_JDBC_CREATE_NAMESPACE_INDEX,·"false");
@@ -96,8 +94,7 @@
················jdbcUrl,·postgreSQLContainer.getUsername(),·postgreSQLContainer.getPassword());
········Statement·stmt·=·conn.createStatement();
········ResultSet·rs·=
-············stmt.executeQuery(
-················"SELECT·1·FROM·pg_indexes·WHERE·indexname·=·'"·+·INDEX_NAME·+·"'"))·{
+············stmt.executeQuery("SELECT·1·FROM·pg_indexes·WHERE·indexname·=·'"·+·INDEX_NAME·+·"'"))·{
······return·rs.next();
····}
··}
Run './gradlew :iceberg:iceberg-common:spotlessApply' to fix these violations.
at com.diffplug.gradle.spotless.SpotlessCheck.performAction(SpotlessCheck.java:111)
at com.diffplug.gradle.spotless.SpotlessCheck.performAction(SpotlessCheck.java:53)
at org.gradle.internal.reflect.JavaMethod.invoke(JavaMethod.java:125)
at org.gradle.api.internal.project.taskfactory.StandardTaskAction.doExecute(StandardTaskAction.java:58)
at org.gradle.api.internal.project.taskfactory.StandardTaskAction.execute(StandardTaskAction.java:51)
at org.gradle.api.internal.project.taskfactory.StandardTaskAction.execute(StandardTaskAction.java:29)
at org.gradle.api.internal.tasks.execution.TaskExecution$3.run(TaskExecution.java:248)
at org.gradle.internal.operations.DefaultBuildOperationRunner$1.execute(DefaultBuildOperationRunner.java:29)
at org.gradle.internal.operations.DefaultBuildOperationRunner$1.execute(DefaultBuildOperationRunner.java:26)
at org.gradle.internal.operations.DefaultBuildOperationRunner$2.execute(DefaultBuildOperationRunner.java:66)
at org.gradle.internal.operations.DefaultBuildOperationRunner$2.execute(DefaultBuildOperationRunner.java:59)
|
|
changes
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: actions/checkout@v4. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
TrinoIT (linux/amd64, 17)
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: actions/checkout@v4, actions/setup-java@v4. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
TrinoIT (linux/amd64, 17)
setup-java v4 is deprecated and will no longer receive updates. Please migrate to actions/setup-java@v5.
|
|
TrinoIT (linux/amd64, 17)
setup-java v4 is deprecated and will no longer receive updates. Please migrate to actions/setup-java@v5.
|