-
Notifications
You must be signed in to change notification settings - Fork 9.2k
YARN-11893. Extend REST API error messages with exception classes #8066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
p-szucs
wants to merge
2
commits into
apache:trunk
Choose a base branch
from
p-szucs:YARN-11893
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+59
−58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I7c08bd438fe17dfed8641f6883d8dbc9566fc771
Contributor
|
Thanks @p-szucs for the fix! Seems good to me. If you can add some basic unit test as well, that would be great! |
|
💔 -1 overall
This message was automatically generated. |
Change-Id: Ifb57f9b4f4acf7965f414954e9e93e88ce300233
slfan1989
approved these changes
Nov 10, 2025
Contributor
|
@p-szucs Thanks for the contribution! Since some changes touch the MapReduce module, I suggest splitting this into two PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I7c08bd438fe17dfed8641f6883d8dbc9566fc771
Description of PR
In GenericExceptionHandler's toResponse method we put only the exception message into the RemoteExceptionData object.
It would be a bit more informative if we would use throwable.toString() instead of throwable.getMessage() as the former extends the error message with the exception class as well, similarly to previous versions.
How was this patch tested?
Tested on a Hadoop cluster
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?