Skip to content

Commit 546de8c

Browse files
NihalJainNihalJain
committed
HBASE-28883 Manage hbase-thirdparty transitive dependencies via BOM pom
1 parent a98a74b commit 546de8c

File tree

2 files changed

+115
-0
lines changed

2 files changed

+115
-0
lines changed

‎hbase-thirdparty-bom/pom.xml

+105
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,105 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<project xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns="http://maven.apache.org/POM/4.0.0"
3+
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
4+
<!--
5+
/**
6+
* Licensed to the Apache Software Foundation (ASF) under one
7+
* or more contributor license agreements. See the NOTICE file
8+
* distributed with this work for additional information
9+
* regarding copyright ownership. The ASF licenses this file
10+
* to you under the Apache License, Version 2.0 (the
11+
* "License"); you may not use this file except in compliance
12+
* with the License. You may obtain a copy of the License at
13+
*
14+
* http://www.apache.org/licenses/LICENSE-2.0
15+
*
16+
* Unless required by applicable law or agreed to in writing, software
17+
* distributed under the License is distributed on an "AS IS" BASIS,
18+
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
19+
* See the License for the specific language governing permissions and
20+
* limitations under the License.
21+
*/
22+
23+
24+
ON MVN COMPILE NOT WORKING
25+
26+
If you wondering why 'mvn compile' does not work building HBase
27+
(in particular, if you are doing it for the first time), instead do
28+
'mvn package'. If you are interested in the full story, see
29+
https://issues.apache.org/jira/browse/HBASE-6795.
30+
31+
-->
32+
<modelVersion>4.0.0</modelVersion>
33+
<parent>
34+
<groupId>org.apache.hbase.thirdparty</groupId>
35+
<artifactId>hbase-thirdparty</artifactId>
36+
<version>${revision}</version>
37+
<relativePath>../pom.xml</relativePath>
38+
</parent>
39+
<artifactId>hbase-thirdparty-bom</artifactId>
40+
<name>Apache HBase Thirdparty - BOM</name>
41+
<description>
42+
Bill of Materials for dependencies common to HBase Thirdparty and HBase main code
43+
</description>
44+
<packaging>pom</packaging>
45+
<dependencyManagement>
46+
<dependencies>
47+
<dependency>
48+
<groupId>com.google.protobuf</groupId>
49+
<artifactId>protobuf-java</artifactId>
50+
<version>${internal.protobuf.version}</version>
51+
</dependency>
52+
<dependency>
53+
<groupId>io.netty</groupId>
54+
<artifactId>netty-bom</artifactId>
55+
<version>${netty4.version}</version>
56+
<type>pom</type>
57+
<scope>import</scope>
58+
</dependency>
59+
<dependency>
60+
<groupId>com.google.errorprone</groupId>
61+
<artifactId>error_prone_annotations</artifactId>
62+
<version>${error_prone_annotations.version}</version>
63+
</dependency>
64+
<dependency>
65+
<groupId>javax.servlet</groupId>
66+
<artifactId>javax.servlet-api</artifactId>
67+
<version>${servlet-api.version}</version>
68+
</dependency>
69+
<dependency>
70+
<groupId>com.fasterxml.jackson.core</groupId>
71+
<artifactId>jackson-annotations</artifactId>
72+
<version>${jackson.version}</version>
73+
</dependency>
74+
<dependency>
75+
<groupId>com.fasterxml.jackson.core</groupId>
76+
<artifactId>jackson-core</artifactId>
77+
<version>${jackson.version}</version>
78+
</dependency>
79+
<dependency>
80+
<groupId>com.fasterxml.jackson.core</groupId>
81+
<artifactId>jackson-databind</artifactId>
82+
<version>${jackson.databind.version}</version>
83+
</dependency>
84+
</dependencies>
85+
</dependencyManagement>
86+
<build>
87+
<plugins>
88+
<plugin>
89+
<groupId>org.codehaus.mojo</groupId>
90+
<artifactId>flatten-maven-plugin</artifactId>
91+
<configuration>
92+
<flattenMode>bom</flattenMode>
93+
</configuration>
94+
<executions>
95+
<execution>
96+
<goals>
97+
<goal>flatten</goal>
98+
</goals>
99+
<phase>process-resources</phase>
100+
</execution>
101+
</executions>
102+
</plugin>
103+
</plugins>
104+
</build>
105+
</project>

‎pom.xml

+10
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@
5353
</license>
5454
</licenses>
5555
<modules>
56+
<module>hbase-thirdparty-bom</module>
5657
<module>hbase-shaded-protobuf</module>
5758
<module>hbase-shaded-netty</module>
5859
<module>hbase-shaded-netty-tcnative</module>
@@ -151,6 +152,15 @@
151152
<jakarta.validation-api.version>2.0.2</jakarta.validation-api.version>
152153
<javassist.version>3.30.2-GA</javassist.version>
153154
<jackson-jaxrs-json-provider.version>2.17.2</jackson-jaxrs-json-provider.version>
155+
<!-- TODO Had added this to see if proprties are passed on via BOM.
156+
Will not work unless we make this as parent to hbase, should drop this before commit.
157+
Keeping here just for demonstration purpose.
158+
-->
159+
<internal.protobuf.version>${protobuf.version}</internal.protobuf.version>
160+
<netty4.version>${netty.version}</netty4.version>
161+
<error-prone.version>${error_prone_annotations.version}</error-prone.version>
162+
<jackson.version>${jackson-jaxrs-json-provider.version}</jackson.version>
163+
<jackson.databind.version>${jackson-jaxrs-json-provider.version}</jackson.databind.version>
154164
</properties>
155165
<build>
156166
<pluginManagement>

0 commit comments

Comments
 (0)