Performance improvement for IsEvacuateFinished (#3037)

xyuanlu · web-flow · commit 3d2e8362ac00 · 2025-05-12T15:03:47.000-07:00
IsEvacuateFinished is calling getChildValues for messages but actually we only need the child names.
diff --git a/helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixAdmin.java b/helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixAdmin.java
@@ -797,7 +797,7 @@ private boolean instanceHasFullAutoCurrentStateOrMessage(String clusterName,
     }
 
     // see if instance has pending message.
-    List<Message> messages = accessor.getChildValues(keyBuilder.messages(instanceName), true);
+    List<String> messages = accessor.getChildNames(keyBuilder.messages(instanceName));
     if (messages != null && !messages.isEmpty()) {
       logger.warn("Instance {} in cluster {} has pending messages.", instanceName, clusterName);
       return true;

Original file line number	Diff line number	Diff line change
`@@ -797,7 +797,7 @@ private boolean instanceHasFullAutoCurrentStateOrMessage(String clusterName,`
`797`	`797`	`}`
`798`	`798`
`799`	`799`	`// see if instance has pending message.`
`800`		`- List<Message> messages = accessor.getChildValues(keyBuilder.messages(instanceName), true);`
	`800`	`+ List<String> messages = accessor.getChildNames(keyBuilder.messages(instanceName));`
`801`	`801`	`if (messages != null && !messages.isEmpty()) {`
`802`	`802`	`logger.warn("Instance {} in cluster {} has pending messages.", instanceName, clusterName);`
`803`	`803`	`return true;`