Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installing plugins will reset UI to default and not reflect already present changes made #1055

Open
ionics opened this issue Jul 26, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@ionics
Copy link

ionics commented Jul 26, 2024

Describe the bug

  • UI changes reflected after "make build"
  • UI changes lost after "./answer build --with example-plugin"

A clear and concise description of what the bug is.

To Reproduce

Steps to reproduce the behavior:

  1. ./answer init -C answer-data/
  2. ./answer run -C answer-data/ => UI changes still present ✅ This is what we want.
  3. Install plugin via cmd: ./answer build --with github.com/apache/incubator-answer-plugins/search-elasticsearch --with github.com/apache/incubator-answer-plugins/cache-redis
  4. Restart app: ./answer run -C answer-data/ => Plugins got installed, but UI changes lost and set to default. 💥

Installing plugins will reset UI to default.

Expected behavior

Installing plugins should not reset UI to default.

Platform

Distributor ID: Ubuntu
Description: Ubuntu 22.04.4 LTS
Release: 22.04
Codename: jammy

answer version 1.3.5
revision: 3ce6925
build time: 1721985092

@ionics ionics added the bug Something isn't working label Jul 26, 2024
@LinkinStars
Copy link
Member

@ionics In step3, you can try to use ANSWER_MODULE=/your-local-answer-source-code-path/incubator-answer ./answer build --with .....

It will use your local code instead of the remote code to build.

@zahash
Copy link
Member

zahash commented Aug 28, 2024

@LinkinStars what remote code?
also, @ionics can you describe what UI changes you made?

@LinkinStars
Copy link
Member

@LinkinStars what remote code? also, @ionics can you describe what UI changes you made?

The remote code is the code that in github repo. Setting the ANSWER_MODULE environment variable allows the user to compile the plugin from local code. Because this user has modified the local UI code, it needs to be built from local.

@ionics
Copy link
Author

ionics commented Oct 18, 2024

@zahash with UI changes i was refering to changes to CSS and style code.

changes present with "run command" but gone after installing plugin via cmd:

./answer build --with github.com/apache/incubator-answer-plugins/search-elasticsearch --with github.com/apache/incubator-answer-plugins/cache-redis

check my post above.

Kind regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants