Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change list/unlist causes tag display exception #1144

Open
fenbox opened this issue Oct 22, 2024 · 1 comment
Open

Change list/unlist causes tag display exception #1144

fenbox opened this issue Oct 22, 2024 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@fenbox
Copy link
Member

fenbox commented Oct 22, 2024

Describe the bug

A clear and concise description of what the bug is.

To Reproduce

Steps to reproduce the behavior:

  1. Unlist a question with two or more tag
  2. Edit the question, remove one tag and add another one
  3. List the question
  4. The removed tag is re-displayed

Expected behavior

Removed tags should not be displayed.

Screenshots

20241022-103014.mp4
@fenbox fenbox added the bug Something isn't working label Oct 22, 2024
@fenbox fenbox added this to the v1.4.2 milestone Oct 22, 2024
@sosyz
Copy link
Member

sosyz commented Oct 26, 2024

@fenbox Hi~
I've identified two issues. First, when restoring hidden tag relationships, we're not filtering out deleted data. Second, when updating questions, the tag relationships default to available status, without considering cases where the question might be hidden.
Please assign this to me, and I'll submit a pull request later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Review
Development

No branches or pull requests

2 participants