Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 Contribute a translation #158

Open
fenbox opened this issue Jan 6, 2023 · 15 comments
Open

🌐 Contribute a translation #158

fenbox opened this issue Jan 6, 2023 · 15 comments

Comments

@fenbox
Copy link
Member

fenbox commented Jan 6, 2023

It's great that you'd like to help us translate Answer into other languages.

Translators do all their work in the Crowdin. Create an account at Crowdin and start translating one or more languages.

After contributing translations to the Crowdin projects, there's nothing more to do. The translations will automatically be pulled into Answer repositories.

@aldotobing
Copy link

Could you please add new language : Indonesia ?

@LinkinStars
Copy link
Member

Could you please add new language : Indonesia ?

We will consider it. If you want to use this language ASAP you can submit a PR to us.

@fenbox
Copy link
Member Author

fenbox commented Jan 31, 2023

@aldotobing Indonesia has been added at Crowdin.

@maxlerebourg
Copy link

Hey, could you validate the translation in Crowdin for every language, even if they aren't 100%. Please.

The project is awesome ! Exactly what we needed in the OpenSource community. Great work !

@fenbox
Copy link
Member Author

fenbox commented Feb 1, 2023

@maxlerebourg Thank you. We have added most popular 30 languages.

There are more than 300 languages in Crowdin. If contributors are willing to participate in the translation language is not listed, we will continue to add.

@maxlerebourg
Copy link

maxlerebourg commented Feb 1, 2023

Sorry, I didn't ask for new available languages. I wasn't clear, on Crowdin, when someone fills in translations, the team that manages the product must approve the new translations.

@fenbox
Copy link
Member Author

fenbox commented Feb 3, 2023

@maxlerebourg I see, we are working on it.

@maxlerebourg
Copy link

Hey, I saw, you just push new version, but unfortunaly, translations isn't handle by this file https://github.com/answerdev/answer/blob/main/ui/src/i18n/init.ts, so french, spanish and other languages are not available.
Moreover, I suggest to not send to client all the language yaml files and fetch it from the back.

@haitaojarvis
Copy link
Contributor

@maxlerebourg Thank you for your feedback!

This question is in two parts.

  1. /i18n/init.ts This file is only used to build in the two languages and do the initialization of the i18n, the other language configurations are loaded on demand. There is no problem with this part.

  2. The problem is that the i18n service does not receive the corresponding data after the on-demand language file has been loaded. We will fix this issue as soon as possible.

Thanks!

@LinkinStars
Copy link
Member

LinkinStars commented Feb 10, 2023

Hey, I saw, you just push new version, but unfortunaly, translations isn't handle by this file https://github.com/answerdev/answer/blob/main/ui/src/i18n/init.ts, so french, spanish and other languages are not available. Moreover, I suggest to not send to client all the language yaml files and fetch it from the back.

The latest docker image has been updated to fix your issue. You can pull the latest docker image again to update it. Then switch to French and try it out, the French translation is almost complete. @maxlerebourg

@den13501
Copy link

I found the French translationissue was solved, but issue is still existed for zh_TW translation.

@LinkinStars
Copy link
Member

image

@den13501 Because French has been translated completely. Traditional Chinese is still being translated. You can check the progress of the translation here.

@den13501
Copy link

image

@den13501 Because French has been translated completely. Traditional Chinese is still being translated. You can check the progress of the translation here.

Thanks for replying, I have just update all zh_TW translation to crowdin, please take time to review it,.

@LinkinStars
Copy link
Member

Thanks for replying, I have just update all zh_TW translation to crowdin, please take time to review it,.

@den13501 Thank you for your contribution to the translation, we will review and approve it ASAP.

@LinkinStars
Copy link
Member

@den13501 The latest docker image already includes the zh_TW translation. You can update it and try it out. There is also some translated content that is still under review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants