Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VL] Add split function to a list to validate regex pattern on Gluten native side #7872

Open
PHILO-HE opened this issue Nov 8, 2024 · 0 comments
Open

[VL] Add split function to a list to validate regex pattern on Gluten native side #7872

PHILO-HE opened this issue Nov 8, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@PHILO-HE
Copy link
Contributor

PHILO-HE commented Nov 8, 2024

Description

We have a check by letting RE2 compiling regex pattern and also filter out some known incompatible cases. Spark split function needs to be added after the implementation in Velox supports regex pattern.

https://github.com/apache/incubator-gluten/blob/main/cpp/velox/substrait/SubstraitToVeloxPlanValidator.cc#L56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PHILO-HE