-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add HTTPS support #191
Comments
@mingfang Thanks for your suggestion, we can indeed be compatible with it, but is there a more user-friendly way where users don't have to prefix it with HTTPS? Welcome your suggestions or improvements |
@imbajin sir maybe we can allow the user to set it themselves? |
@chiruu12 OK, a simple idea is to determine whether the first character of the IP/URI_PREFIX param is a number:
This way, ordinary users can directly write the IP and maintain compatibility with HTTPS/HTTP |
@imbajin sir this can be an approach, but we can make it better by using regex filter instead just checking the first character can cause problem as some website like 365x.ai will be having the first character as a number but it is a URI not IP I found a regex pattern for IPv4 Addresses which is
using this we can assure that we are categorizing the IP/URI properly and this approach would allow users to input addresses without worrying about the correct protocol prefix, enhancing usability. What are your thoughts on this solution? |
@chiruu12 It reminds me that we don't need to distinguish between domain names and IP. Some user input like:
We just need to construct a valid URI, and the logic can be simplified as checking whether the IP field prefix is
Seems no need to use regex pattern? |
Currently hardcoded to HTTP only.
incubator-hugegraph-ai/hugegraph-python-client/src/pyhugegraph/utils/huge_requests.py
Line 112 in ca28faf
The text was updated successfully, but these errors were encountered: