Skip to content

KAFKA-19874: Fix resource leak in TopicBasedRemoteLogMetadataManager. #20849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
+11 −3
Open

KAFKA-19874: Fix resource leak in TopicBasedRemoteLogMetadataManager. #20849

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions ...g/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,19 +345,27 @@ private void initializeResources(TopicBasedRemoteLogMetadataManagerConfig rlmmCo
continue;
}
// Create producer and consumer managers.
ProducerManager tempProducerManager = null;
ConsumerManager tempConsumerManager = null;
lock.writeLock().lock();
try {
producerManager = new ProducerManager(rlmmConfig, partitioner);
consumerManager = new ConsumerManager(rlmmConfig, remotePartitionMetadataStore, partitioner, time);
consumerManager.startConsumerThread();
tempProducerManager = new ProducerManager(rlmmConfig, partitioner);
tempConsumerManager = new ConsumerManager(rlmmConfig, remotePartitionMetadataStore, partitioner, time);
tempConsumerManager.startConsumerThread();
if (!pendingAssignPartitions.isEmpty()) {
assignPartitions(pendingAssignPartitions);
pendingAssignPartitions.clear();
}
// Only assign to instance variables after successful initialization
producerManager = tempProducerManager;
consumerManager = tempConsumerManager;
initialized.set(true);
log.info("Initialized topic-based RLMM resources successfully");
} catch (Exception e) {
log.error("Encountered error while initializing producer/consumer", e);
// Clean up resources if initialization fails
Utils.closeQuietly(tempConsumerManager, "ConsumerManager");
Utils.closeQuietly(tempProducerManager, "ProducerManager");
initializationFailed = true;
} finally {
lock.writeLock().unlock();
Expand Down
Loading