Code analysis fixes

Author: paulirwin

src/Lucene.Net.Replicator/Http/HttpClientBase.cs

@@ -1,4 +1,3 @@
-using Lucene.Net.Diagnostics;
 using Lucene.Net.Support;
 using System;
 using System.IO;
@@ -7,6 +6,8 @@
 using System.Net.Http;
 using System.Threading;
 using System.Threading.Tasks;
+// ReSharper disable VirtualMemberNeverOverridden.Global
+// ReSharper disable MemberCanBePrivate.Global
 
 #nullable enable
 
@@ -396,7 +397,8 @@ protected virtual T DoAction<T>(HttpResponseMessage response, bool consume, Func
                     }
                 }
             }
-            if (Debugging.AssertsEnabled) Debugging.Assert(th != null); // extra safety - if we get here, it means the Func<T> failed
+
+            // if (Debugging.AssertsEnabled) Debugging.Assert(th != null); // LUCENENET: Removed assertion because it'll never be null here, ensured by NRT
             Util.IOUtils.ReThrow(th);
             return default!; // silly, if we're here, IOUtils.reThrow always throws an exception
         }
@@ -408,7 +410,7 @@ protected virtual T DoAction<T>(HttpResponseMessage response, bool consume, Func
         /// </summary>
         protected virtual async Task<T> DoActionAsync<T>(HttpResponseMessage response, bool consume, Func<Task<T>> call)
         {
-            Exception? th = null;
+            Exception? th /* = null */;
             try
             {
                 VerifyStatus(response);
@@ -440,8 +442,8 @@ protected virtual async Task<T> DoActionAsync<T>(HttpResponseMessage response, b
                 }
             }
 
-            if (Debugging.AssertsEnabled) Debugging.Assert(th != null);
-            Util.IOUtils.ReThrow(th!);
+            // if (Debugging.AssertsEnabled) Debugging.Assert(th != null); // LUCENENET: Removed assertion because it'll never be null here, ensured by NRT
+            Util.IOUtils.ReThrow(th);
             return default!; // never reached, rethrow above always throws
         }
 
@@ -496,7 +498,7 @@ private static void ConsumeQuietly(HttpResponseMessage response)
         private class ConsumingStream : Stream
         {
             private readonly Stream input;
-            private bool consumed = false;
+            private bool consumed /* = false */;
 
             public ConsumingStream(Stream input)
             {

src/Lucene.Net.Replicator/Http/HttpReplicator.cs

@@ -128,16 +128,17 @@ public virtual void Release(string sessionId)
         public async Task<SessionToken?> CheckForUpdateAsync(string? currentVersion, CancellationToken cancellationToken = default)
         {
             string[]? parameters = !string.IsNullOrEmpty(currentVersion)
-                ? new[] { ReplicationService.REPLICATE_VERSION_PARAM, currentVersion! }
+                ? new[] { ReplicationService.REPLICATE_VERSION_PARAM, currentVersion! } // [!]: verified above
                 : null;
 
             using var response = await ExecuteGetAsync(
-                ReplicationService.ReplicationAction.UPDATE.ToString(),
-                parameters ?? Array.Empty<string>(),
+                nameof(ReplicationService.ReplicationAction.UPDATE),
+                parameters,
                 cancellationToken: cancellationToken).ConfigureAwait(false);
 
             return await DoActionAsync(response, async () =>
             {
+                // ReSharper disable once AccessToDisposedClosure - DoActionAsync definitively returns after this lambda is invoked
                 using var inputStream = new DataInputStream(
                     await GetResponseStreamAsync(response, cancellationToken).ConfigureAwait(false));
 
@@ -156,16 +157,16 @@ public virtual void Release(string sessionId)
         public async Task<Stream> ObtainFileAsync(string sessionId, string source, string fileName, CancellationToken cancellationToken = default)
         {
             using var response = await ExecuteGetAsync(
-                ReplicationService.ReplicationAction.OBTAIN.ToString(),
+                nameof(ReplicationService.ReplicationAction.OBTAIN),
                 ReplicationService.REPLICATE_SESSION_ID_PARAM, sessionId,
                 ReplicationService.REPLICATE_SOURCE_PARAM, source,
                 ReplicationService.REPLICATE_FILENAME_PARAM, fileName,
                 cancellationToken: cancellationToken).ConfigureAwait(false);
 
-            return await DoActionAsync(response, async () =>
-            {
-                return await GetResponseStreamAsync(response, cancellationToken).ConfigureAwait(false);
-            }).ConfigureAwait(false);
+            return await DoActionAsync(response,
+                    // ReSharper disable once AccessToDisposedClosure - DoActionAsync definitively returns after this lambda is invoked
+                    async () => await GetResponseStreamAsync(response, cancellationToken).ConfigureAwait(false))
+                .ConfigureAwait(false);
         }
 
         /// <summary>
@@ -191,7 +192,7 @@ public Task PublishAsync(IRevision revision, CancellationToken cancellationToken
         public async Task ReleaseAsync(string sessionId, CancellationToken cancellationToken = default)
         {
             using var response = await ExecuteGetAsync(
-                ReplicationService.ReplicationAction.RELEASE.ToString(),
+                nameof(ReplicationService.ReplicationAction.RELEASE),
                 ReplicationService.REPLICATE_SESSION_ID_PARAM, sessionId,
                 cancellationToken: cancellationToken).ConfigureAwait(false);
 
@@ -206,4 +207,3 @@ await DoActionAsync(response, () =>
 
     }
 }
-#nullable restore

src/Lucene.Net/Util/IOUtils.cs

@@ -6,6 +6,7 @@
 using System;
 using System.Collections.Generic;
 using System.Diagnostics;
+using System.Diagnostics.CodeAnalysis;
 using System.IO;
 using System.Runtime.CompilerServices;
 using System.Runtime.ExceptionServices;
@@ -627,13 +628,14 @@ public static void Copy(FileInfo source, FileInfo target)
             }
         }
 
+        #nullable enable
         /// <summary>
-        /// Simple utilty method that takes a previously caught
+        /// Simple utility method that takes a previously caught
         /// <see cref="Exception"/> and rethrows either
         /// <see cref="IOException"/> or an unchecked exception.  If the
         /// argument is <c>null</c> then this method does nothing.
         /// </summary>
-        public static void ReThrow(Exception th)
+        public static void ReThrow(Exception? th) // LUCENENET TODO: determine if we can remove the nullability here
         {
             if (th != null)
             {
@@ -646,11 +648,11 @@ public static void ReThrow(Exception th)
         }
 
         /// <summary>
-        /// Simple utilty method that takes a previously caught
+        /// Simple utility method that takes a previously caught
         /// <see cref="Exception"/> and rethrows it as an unchecked exception.
         /// If the argument is <c>null</c> then this method does nothing.
         /// </summary>
-        public static void ReThrowUnchecked(Exception th)
+        public static void ReThrowUnchecked(Exception? th) // LUCENENET TODO: determine if we can remove the nullability here
         {
             if (th != null)
             {
@@ -661,6 +663,7 @@ public static void ReThrowUnchecked(Exception th)
                 throw RuntimeException.Create(th);
             }
         }
+        #nullable restore
 
         // LUCENENET specific: using string instead of FileSystemInfo to avoid extra allocation
         public static void Fsync(string fileToSync, bool isDir)