[POC-FIX-PMD] maven-pmd-plugin: reactivate PMD - UnusedPrivateMethod

Author: Vincent Potucek

impl/maven-core/src/main/java/org/apache/maven/internal/transformation/impl/DefaultConsumerPomArtifactTransformer.java

@@ -46,7 +46,6 @@
 import org.eclipse.aether.artifact.DefaultArtifact;
 import org.eclipse.aether.deployment.DeployRequest;
 import org.eclipse.aether.installation.InstallRequest;
-import org.eclipse.sisu.PreDestroy;
 
 /**
  * Consumer POM transformer.
@@ -117,17 +116,6 @@ private void deferDeleteFile(Path generatedFile) {
         toDelete.add(generatedFile.toAbsolutePath());
     }
 
-    @PreDestroy
-    private void doDeleteFiles() {
-        for (Path file : toDelete) {
-            try {
-                Files.delete(file);
-            } catch (IOException e) {
-                // ignore, we did our best...
-            }
-        }
-    }
-
     public InstallRequest remapInstallArtifacts(RepositorySystemSession session, InstallRequest request) {
         if (consumerPomPresent(request.getArtifacts())) {
             request.setArtifacts(replacePom(request.getArtifacts()));

impl/maven-xml/src/main/java/org/apache/maven/internal/xml/DefaultXmlService.java

@@ -392,34 +392,6 @@ private static String getChildCombinationMode(Map<String, String> attributes) {
         return !isEmpty(value) ? value : DEFAULT_CHILDREN_COMBINATION_MODE;
     }
 
-    @Nullable
-    private static XmlNode findNodeById(@Nonnull List<XmlNode> nodes, @Nonnull String id) {
-        return nodes.stream()
-                .filter(n -> id.equals(n.attribute(ID_COMBINATION_MODE_ATTRIBUTE)))
-                .findFirst()
-                .orElse(null);
-    }
-
-    @Nullable
-    private static XmlNode findNodeByKeys(
-            @Nonnull List<XmlNode> nodes, @Nonnull XmlNode target, @Nonnull String[] keys) {
-        return nodes.stream()
-                .filter(n -> matchesKeys(n, target, keys))
-                .findFirst()
-                .orElse(null);
-    }
-
-    private static boolean matchesKeys(@Nonnull XmlNode node1, @Nonnull XmlNode node2, @Nonnull String[] keys) {
-        for (String key : keys) {
-            String value1 = node1.attribute(key);
-            String value2 = node2.attribute(key);
-            if (!Objects.equals(value1, value2)) {
-                return false;
-            }
-        }
-        return true;
-    }
-
     static class IndentingXMLStreamWriter extends StreamWriterDelegate {
 
         int depth = 0;