[POC-FIX-PMD] maven-pmd-plugin: reactivate PMD - Error Prone

Author: Vincent Potucek

.pmd/exclude.properties

@@ -88,7 +88,6 @@ org.apache.maven.lifecycle.DefaultLifecycles=UnusedFormalParameter
 org.apache.maven.lifecycle.LifecycleExecutionException=UnusedFormalParameter
 org.apache.maven.lifecycle.internal.DefaultLifecycleExecutionPlanCalculator=UselessParentheses
 org.apache.maven.lifecycle.internal.DefaultLifecycleTaskSegmentCalculator=UselessParentheses
-org.apache.maven.lifecycle.internal.MojoExecutor=UnusedLocalVariable
 org.apache.maven.lifecycle.internal.builder.BuilderCommon=EmptyControlStatement
 org.apache.maven.lifecycle.internal.concurrent.BuildContext=CollapsibleIfStatements,EmptyControlStatement,UnusedLocalVariable
 org.apache.maven.lifecycle.internal.concurrent.BuildPlanExecutor=TooManyStaticImports,UselessParentheses
@@ -121,7 +120,6 @@ org.apache.maven.repository.internal.DefaultModelResolver=UnnecessaryFullyQualif
 org.apache.maven.repository.internal.LocalSnapshotMetadataGenerator=UnusedFormalParameter
 org.apache.maven.repository.internal.scopes.Maven3ScopeManagerConfiguration=TooManyStaticImports,UnnecessaryFullyQualifiedName
 org.apache.maven.repository.internal.scopes.Maven4ScopeManagerConfiguration=TooManyStaticImports,UnnecessaryFullyQualifiedName
-org.apache.maven.repository.legacy.DefaultUpdateCheckManager=UnusedLocalVariable
 org.apache.maven.repository.legacy.DefaultWagonManager=UnusedFormalParameter
 org.apache.maven.repository.legacy.LegacyRepositorySystem=UnnecessaryFullyQualifiedName
 org.apache.maven.repository.legacy.resolver.DefaultLegacyArtifactCollector=CollapsibleIfStatements

compat/maven-compat/src/main/java/org/apache/maven/repository/legacy/DefaultUpdateCheckManager.java

@@ -303,7 +303,7 @@ private Properties read(File touchfile) {
                 Properties props = new Properties();
 
                 try (FileInputStream in = new FileInputStream(touchfile)) {
-                    try (FileLock lock = in.getChannel().lock(0, Long.MAX_VALUE, true)) {
+                    try (FileLock ignored = in.getChannel().lock(0, Long.MAX_VALUE, true)) {
                         getLogger().debug("Reading resolution-state from: " + touchfile);
                         props.load(in);
 

impl/maven-core/src/main/java/org/apache/maven/lifecycle/internal/MojoExecutor.java

@@ -306,7 +306,7 @@ private void doExecute(MavenSession session, MojoExecution mojoExecution, Depend
 
         ensureDependenciesAreResolved(mojoDescriptor, session, dependencyContext);
 
-        try (NoExceptionCloseable lock = getProjectLock(session, mojoDescriptor)) {
+        try (NoExceptionCloseable ignored = getProjectLock(session, mojoDescriptor)) {
             doExecute2(session, mojoExecution);
         } finally {
             for (MavenProject forkedProject : forkedProjects) {