chore: drop obsolete DefaultXmlService#findNodeById
#2334
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pankraz76
force-pushed
the
UnusedPrivateMethod
branch
from
40f1259 to
5499b8c
Compare
Pankraz76
commented
May 13, 2025
...ava/org/apache/maven/internal/transformation/impl/DefaultConsumerPomArtifactTransformer.java
Show resolved
Hide resolved
Pankraz76
commented
May 13, 2025
impl/maven-xml/src/main/java/org/apache/maven/internal/xml/DefaultXmlService.java
Show resolved
Hide resolved
Pankraz76
changed the title
maven-pmd-plugin: reactivate PMD - UnusedPrivateMethod
Pankraz76
changed the title
Pankraz76
changed the title
Pankraz76
force-pushed
the
UnusedPrivateMethod
branch
from
5499b8c to
e6cf9d1
Compare
Pankraz76
force-pushed
the
UnusedPrivateMethod
branch
from
e6cf9d1 to
e999ea8
Compare
Pankraz76
changed the title
#findNodeById #findNodeByKeys #matchesKeys
Pankraz76
changed the title
#findNodeById #findNodeByKeys #matchesKeysfindNodeById findNodeByKeys matchesKeys
Pankraz76
changed the title
findNodeById findNodeByKeys matchesKeysDefaultXmlService PMD-Rule: UnusedPrivateMethod
Pankraz76
commented
Jun 7, 2025
Contributor
Author
Pankraz76
left a comment
Pankraz76
left a comment
There was a problem hiding this comment.
cant spell clean without lean.
impl/maven-xml/src/main/java/org/apache/maven/internal/xml/DefaultXmlService.java
Show resolved
Hide resolved
Pankraz76
changed the title
DefaultXmlService PMD-Rule: UnusedPrivateMethodDefaultXmlService#findNodeById
Pankraz76
changed the title
DefaultXmlService#findNodeByIdDefaultXmlService#findNodeById
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.