Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: multiple file with same name in google drive crash #5099

Open
1 task
qkzk opened this issue Sep 5, 2024 · 3 comments
Open
1 task

bug: multiple file with same name in google drive crash #5099

qkzk opened this issue Sep 5, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@qkzk
Copy link

qkzk commented Sep 5, 2024

Describe the bug

While debugging and trying to list a google drive, if multiple files have the same name exactly, the application crash.
For some reason, GoogleDrive allows multiple files to have exactly the same name.

This is handled here and this check is disabled in release mode.

Steps to Reproduce

Connect to a google drive with two files having exactly the same name and do a op.list(...)

Expected Behavior

I guess the simplest is to completely ignore the file and not crash or simply log an error somewhere.

At least, the error and comment should be more precise.

Additional Context

I'm new to the library, sorry if it's the expected behavior or if there's another issue about it. I couldn't find anything about that.

Are you willing to submit a PR to fix this bug?

  • Yes, I would like to submit a PR.
@qkzk qkzk added the bug Something isn't working label Sep 5, 2024
@Xuanwo
Copy link
Member

Xuanwo commented Sep 5, 2024

I used to think we should prohibit this case, but I've somewhat changed my mind. I now believe that we can simply permit such cases and only select the newest one while read and returning all of them during the list.

Anyway, we can ignore the file at first. Would you like to help implement it?

@qkzk
Copy link
Author

qkzk commented Sep 5, 2024

I'll take a look !

@qkzk
Copy link
Author

qkzk commented Sep 5, 2024

Something as simple as that ?

@qkzk qkzk mentioned this issue Sep 9, 2024
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants