You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
CRC32C is the algorithm recommended in the official documentation of GCS, and because OpenDAL S3 already provides a CRC32C checksum implementation, I think it is intuitive to add CRC32C checksum support to GCS.
Hi, before making an effort to add more checksum support to the services, I'm interested in discussing how we can achieve end-to-end checksum support at #5549.
Hi, @Xuanwo , thank you very much for your suggestions. I think we can first list some common services that support checksum algorithms, which may include the supported checksum algorithms, the use of checksum algorithms in different read and write methods, the scope of data verification, etc. I would be happy to find and provide a list like this.
In addition, after choosing some common checksum algorithms, maybe these services will initially just rely on these common functions and expose them to users by setting configuration like we do now, and then consider refactoring this part by possibly adding layers; or perhaps from the beginning, the most general design considerations are used to determine the future application mode of checksum in OpenDAL, and implement it on this basis.
I think the advantage of the first approach is that we can implement checksum for the most commonly used services first and accumulate knowledge for future general designs in the process. The advantage of the second approach is that if we design it clearly from the beginning, we can avoid repeated implementation.
These are some of my simple ideas, and hope to get any suggestions. 💗
Feature Description
CRC32C is the algorithm recommended in the official documentation of GCS, and because OpenDAL S3 already provides a CRC32C checksum implementation, I think it is intuitive to add CRC32C checksum support to GCS.
Problem and Solution
GCS Docs: https://cloud.google.com/storage/docs/data-validation.
Additional Context
No response
Are you willing to contribute to the development of this feature?
The text was updated successfully, but these errors were encountered: