Avoid hitting the GitHub API

[raboof]

It seems the Material theme hits the GitHub API pretty hard, fetching all repo's under the org, presumably to show the "X starts, Y forks" statistic in the top-right column. It seems to be cached, but still, is that really worth it?

[pjfanning]

It ends up with GitHub blocking the calls due to rate limits (because they are not authenticated)

[mdedetrich]

I think we can prevent this by propagating the GITHUB_TOKEN (which is provided to the github CI runners) to the REST calls

[raboof]

This is about the client-side javascript, not the build process

[mdedetrich]

This is about the client-side javascript, not the build process

Oh I see, nvm then.

[pjfanning]

This is a pretty high priority. We need to stop making these calls altogether as it against ASF policy policy to make calls to 3rd party sites like this.

https://lists.apache.org/thread/29ft4ypt6vps30n877q69pj11kzx73c8

https://privacy.apache.org/policies/privacy-policy-public.html

[samueleresca]

The js code look for the data-source-md="github" elements to trigger the github API call. I think removing that attribute from: https://github.com/apache/incubator-pekko-site/blob/3b7e6c3bbb49a411de04577bc06e7ad52121dfc7/content/lib/paradox-material-theme/partials/source.st#L26 should do the job

[samueleresca]

The js code look for the data-source-md="github" elements to trigger the github API call. I think removing that attribute from: https://github.com/apache/incubator-pekko-site/blob/3b7e6c3bbb49a411de04577bc06e7ad52121dfc7/content/lib/paradox-material-theme/partials/source.st#L26 should do the job

Note that this won't remove the calling code from the sources, It will not trigger the call to the 3rd party API.

@pjfanning I should be able to take a look at this tomorow

[pjfanning]

The js code look for the data-source-md="github" elements to trigger the github API call. I think removing that attribute from: https://github.com/apache/incubator-pekko-site/blob/3b7e6c3bbb49a411de04577bc06e7ad52121dfc7/content/lib/paradox-material-theme/partials/source.st#L26 should do the job

Note that this won't remove the calling code from the sources, It will not trigger the call to the 3rd party API.

@pjfanning I should be able to take a look at this tomorow

Thanks @samueleresca - much appreciated. I had to allow the api.github.com calls in our Content-Security-Policy header (see the .htaccess in incubator-pekko-site). Ideally, we should be able to remove that put we may not be able to remove that immediately. If we can get your change working, we can come back again with a bigger change to remove the source that can call api.github.com altogether.

[samueleresca]

#121 Fixed this in the short term. The code calling the API is still there, but not executed. For a complete solution we should look at removing the calling code entirely.

Note that the fix should be also compatible with the new mkdocs-material v9.x (see: sbt/sbt-paradox-material-theme#75)