PHOENIX-7430 Remove commons-collections dependency in queryserver (#163)

- Also remove imports and replace with equivalent code

Author: NihalJain

phoenix-queryserver/pom.xml

@@ -215,10 +215,6 @@
       <groupId>org.slf4j</groupId>
       <artifactId>slf4j-api</artifactId>
     </dependency>
-    <dependency>
-      <groupId>commons-collections</groupId>
-      <artifactId>commons-collections</artifactId>
-    </dependency>
     <dependency>
       <groupId>com.google.code.findbugs</groupId>
       <artifactId>jsr305</artifactId>

phoenix-queryserver/src/main/java/org/apache/phoenix/util/InstanceResolver.java

@@ -17,8 +17,7 @@
  */
 package org.apache.phoenix.util;
 
-import org.apache.commons.collections.IteratorUtils;
-
+import java.util.ArrayList;
 import java.util.Iterator;
 import java.util.List;
 import java.util.ServiceLoader;
@@ -68,10 +67,13 @@ public static <T> T getSingleton(Class<T> clazz, T defaultInstance) {
     @SuppressWarnings("unchecked")
     public static <T> List get(Class<T> clazz, List<T> defaultInstances) {
         Iterator<T> iterator = ServiceLoader.load(clazz).iterator();
+        List<T> instances = new ArrayList<>();
+        iterator.forEachRemaining(instances::add);
+
         if (defaultInstances != null) {
-            defaultInstances.addAll(IteratorUtils.toList(iterator));
+            defaultInstances.addAll(instances);
         } else {
-            defaultInstances = IteratorUtils.toList(iterator);
+            defaultInstances = instances;
         }
 
         return defaultInstances;

pom.xml

@@ -85,7 +85,6 @@
         <jetty.version>9.4.53.v20231009</jetty.version>
         <netty-bom.version>4.1.108.Final</netty-bom.version>
         <commons-io.version>2.14.0</commons-io.version>
-        <commons-collections.version>3.2.2</commons-collections.version>
         <sqlline.version>1.9.0</sqlline.version>
         <slf4j.version>1.7.36</slf4j.version>
         <avatica.version>1.25.0</avatica.version>
@@ -729,12 +728,6 @@
                   </exclusion>
                 </exclusions>
             </dependency>
-
-            <dependency>
-              <groupId>commons-collections</groupId>
-              <artifactId>commons-collections</artifactId>
-              <version>${commons-collections.version}</version>
-            </dependency>
             <dependency>
                 <groupId>org.apache.calcite.avatica</groupId>
                 <artifactId>avatica</artifactId>