PHOENIX-7442 Apply Spotless to reformat the entire codebase

Author: NihalJain

BUILDING.md

@@ -59,12 +59,12 @@ Building from source
 On first setup, you may need to run `$ mvn install -DskipTests`
 to install the local jars. This is a side-effect of multi-module maven projects
 
-To re-generate the antlr based files:  
+To re-generate the antlr based files:
 `$ mvn process-sources`
 
-To build the jars and the assembly tarball:  
+To build the jars and the assembly tarball:
 `$ mvn package`
-and optionally, to just skip all the tests and build the jars:  
+and optionally, to just skip all the tests and build the jars:
 `$ mvn package -DskipTests`
 
 Note: javadocs are generated in target/apidocs
@@ -79,7 +79,7 @@ Phoenix, even within the same HBase minor release.
 By default, Phoenix will be built for the latest known patch level of the latest HBase 2.x
 minor release that Phoenix supports.
 
-You can specify the targeted HBase minor release by setting the `hbase.profile` system property for 
+You can specify the targeted HBase minor release by setting the `hbase.profile` system property for
 maven.
 
 You can also specify the exact HBase release to build Phoenix with by additionally
@@ -102,7 +102,7 @@ Use the m2e eclipse plugin and do Import->Maven Project and just pick the root '
 Running the tests
 -----------------
 
-All Unit Tests  
+All Unit Tests
 `$ mvn clean test`
 
 All Unit Tests and Integration tests (takes a few hours)
@@ -133,5 +133,5 @@ as well as each of the subprojects. (not every project has all reports)
 Generate Apache Web Site
 ------------------------
 
-checkout https://svn.apache.org/repos/asf/phoenix  
+checkout https://svn.apache.org/repos/asf/phoenix
 `$ build.sh`

Jenkinsfile

@@ -116,4 +116,4 @@ pipeline {
             }
         }
     }
-}
+}

Jenkinsfile.yetus

@@ -55,4 +55,4 @@ pipeline {
             }
         }
     }
-}
+}

README.md

@@ -19,4 +19,4 @@ limitations under the License.
 
 <b>[Apache Phoenix](http://phoenix.apache.org/)</b> is a SQL skin over HBase delivered as a client-embedded JDBC driver targeting low latency queries over HBase data. Visit the Apache Phoenix website <b>[here](http://phoenix.apache.org/)</b>.
 
-Copyright ©2014 [Apache Software Foundation](http://www.apache.org/). All Rights Reserved. 
+Copyright ©2014 [Apache Software Foundation](http://www.apache.org/). All Rights Reserved.

bin/end2endTest.py

@@ -21,7 +21,7 @@
 
 # !!!  PLEASE READ !!!
 # !!!  Do NOT run the script against a prodcution cluster because it wipes out
-# !!!  existing data of the cluster 
+# !!!  existing data of the cluster
 
 from __future__ import print_function
 import os

bin/pherf-standalone.py

@@ -40,6 +40,6 @@
     phoenix_utils.phoenix_pherf_jar + \
     '" -Dlog4j2.configurationFile=file:' + \
     os.path.join(phoenix_utils.current_dir, "log4j2.properties") + \
-    " org.apache.phoenix.pherf.Pherf " + args 
+    " org.apache.phoenix.pherf.Pherf " + args
 
 os.execl("/bin/sh", "/bin/sh", "-c", java_cmd)

bin/phoenix_utils.py

@@ -33,14 +33,14 @@ def find(pattern, classPaths):
         # remove * if it's at the end of path
         if ((path is not None) and (len(path) > 0) and (path[-1] == '*')) :
             path = path[:-1]
-    
+
         for root, dirs, files in os.walk(path):
             # sort the file names so *-client always precedes *-thin-client
             files.sort()
             for name in files:
                 if fnmatch.fnmatch(name, pattern):
                     return os.path.join(root, name)
-                
+
     return ""
 
 def tryDecode(input):

bin/psql.py

@@ -36,7 +36,7 @@
     os.pathsep + phoenix_utils.logging_jar + \
     os.pathsep + phoenix_utils.phoenix_client_embedded_jar + '" -Dlog4j2.configurationFile=file:' + \
     os.path.join(phoenix_utils.current_dir, "log4j2.properties") + \
-    " org.apache.phoenix.util.PhoenixRuntime " + args 
+    " org.apache.phoenix.util.PhoenixRuntime " + args
 
 print(java_cmd)
 

bin/readme.txt

@@ -3,10 +3,10 @@ SqlLine
 https://github.com/julianhyde/sqlline
 
 Execute SQL from command line. Sqlline manual is available at https://julianhyde.github.io/sqlline/manual.html
-	
-	Usage: 
-	$ sqlline.py <zookeeper> <optional_sql_file> 
-	Example: 
+
+	Usage:
+	$ sqlline.py <zookeeper> <optional_sql_file>
+	Example:
 	$ sqlline.py localhost
 	$ sqlline.py localhost <examples dir>/STOCK_SYMBOL.sql
 
@@ -47,4 +47,3 @@ Usage: hadoop jar phoneix-[version]-mapreduce.jar <parameters>
  -s,--schema <arg>            Phoenix schema name (optional)
  -t,--table <arg>             Phoenix table name (mandatory)
  -z,--zookeeper <arg>         Zookeeper quorum to connect to (optional)
-

bin/traceserver.py

@@ -123,7 +123,7 @@
     phoenix_utils.phoenix_traceserver_jar + os.pathsep + phoenix_utils.slf4j_backend_jar + os.pathsep + \
     phoenix_utils.logging_jar + os.pathsep + \
     phoenix_utils.phoenix_client_embedded_jar + os.pathsep + phoenix_utils.phoenix_queryserver_jar + \
-    
+
     " -Dproc_phoenixtraceserver" + \
     " -Dlog4j2.configurationFile=file:" + os.path.join(phoenix_utils.current_dir, "log4j2.properties") + \
     " -Dpsql.root.logger=%(root_logger)s" + \

dev/PhoenixCodeTemplate.xml

@@ -415,4 +415,4 @@
         <setting id="org.eclipse.jdt.core.formatter.insert_space_after_opening_paren_in_annotation" value="do not insert"/>
         <setting id="org.eclipse.jdt.core.formatter.insert_space_before_opening_paren_in_switch" value="insert"/>
     </profile>
-</profiles>
+</profiles>

dev/cache-apache-project-artifact.sh

@@ -138,4 +138,4 @@ echo "moving artifact into place at '${target}'"
 mv "${working_dir}/artifact" "${target}.copying"
 # attempt atomic move
 mv "${target}.copying" "${target}"
-echo "all done!"
+echo "all done!"

dev/create-release/release-util.sh

@@ -771,4 +771,4 @@ function rebuild_hbase_for_omid() {
 function rebuild_hbase_locally() {
   local hbase_version="$1"
   MAVEN_SETTINGS_FILE="$MAVEN_SETTINGS_FILE" "$SELF"/rebuild_hbase.sh "$hbase_version"
-}
+}

dev/jenkinsEnv.sh

@@ -28,4 +28,3 @@ export PATH=$PATH:$JAVA_HOME/bin:$ANT_HOME/bin:$MAVEN_HOME/bin
 export MAVEN_OPTS="${MAVEN_OPTS:-"-Xmx3100M -XX:-UsePerfData -XX:MaxPermSize=256m"}"
 
 ulimit -n
-

dev/misc_utils/README.md

@@ -72,11 +72,11 @@ The script also requires below inputs:
 
 Example of script execution:
 ```
-$ python3 dev/misc_utils/git_jira_fix_version_check.py 
+$ python3 dev/misc_utils/git_jira_fix_version_check.py
 JIRA Project Name (e.g PHOENIX / OMID / TEPHRA etc): PHOENIX
 First commit hash to start excluding commits from history: a2adf5e572c5a4bcccee7f8ac43bad6b84293ec6
 Fix Version: 4.16.0
-Jira server url (default: https://issues.apache.org/jira): 
+Jira server url (default: https://issues.apache.org/jira):
 Path of project's working dir with release branch checked-in: /Users/{USER}/Documents/phoenix
 
 Check git status output and verify expected branch
@@ -114,5 +114,3 @@ Completed diff: ##############################################
 
 
 ```
-
-

dev/rebuild_hbase.sh

@@ -73,4 +73,3 @@ cd hbase-$HBASE_VERSION
 echo mvn ${SETTINGS[@]} clean install -Dhadoop.profile=3.0 -DskipTests -B $LOCALREPO
 mvn ${SETTINGS[@]} clean install -Dhadoop.profile=3.0 -DskipTests -B $LOCALREPO
 cd ${STARTDIR}
-

dev/smart-apply-patch.sh

@@ -52,7 +52,7 @@ if $PATCH -p0 -E --dry-run < $PATCH_FILE 2>&1 > $TMP; then
   # correct place to put those files.
 
 #  NOTE 2014/07/17:
-#  Temporarily disabling below check since our jenkins boxes seems to be not defaulting to bash 
+#  Temporarily disabling below check since our jenkins boxes seems to be not defaulting to bash
 #  causing below checks to fail. Once it is fixed, we can revert the commit and enable this again.
 
 #  TMP2=/tmp/tmp.paths.2.$$

dev/test-patch.sh

@@ -19,7 +19,7 @@
 
 set -x
 
-### Setup some variables.  
+### Setup some variables.
 ### GIT_COMMIT and BUILD_URL are set by Hudson if it is run by patch process
 ### Read variables from properties file
 bindir=$(dirname $0)
@@ -160,7 +160,7 @@ parseArgs() {
     ### Check if $PATCH_DIR exists. If it does not exist, create a new directory
     if [[ ! -e "$PATCH_DIR" ]] ; then
       mkdir "$PATCH_DIR"
-      if [[ $? == 0 ]] ; then 
+      if [[ $? == 0 ]] ; then
         echo "$PATCH_DIR has been created"
       else
         echo "Unable to create $PATCH_DIR"
@@ -296,7 +296,7 @@ setup () {
     VERSION=${GIT_COMMIT}_${defect}_PATCH-${patchNum}
     findBranchNameFromPatchName ${relativePatchURL}
     checkoutBranch
-    JIRA_COMMENT="Here are the results of testing the latest attachment 
+    JIRA_COMMENT="Here are the results of testing the latest attachment
   $patchURL
   against ${BRANCH_NAME} branch at commit ${GIT_COMMIT}.
   ATTACHMENT ID: ${ATTACHMENT_ID}"
@@ -485,7 +485,7 @@ applyPatch () {
   echo "======================================================================"
   echo ""
   echo ""
- 
+
   export PATCH
   $BASEDIR/dev/smart-apply-patch.sh $PATCH_DIR/patch
   if [[ $? != 0 ]] ; then
@@ -786,7 +786,7 @@ checkFindbugsWarnings () {
   echo "======================================================================"
   echo ""
   echo ""
-  echo "$MVN clean package findbugs:findbugs -D${PROJECT_NAME}PatchProcess" 
+  echo "$MVN clean package findbugs:findbugs -D${PROJECT_NAME}PatchProcess"
   export MAVEN_OPTS="${MAVEN_OPTS}"
   $MVN clean package findbugs:findbugs -D${PROJECT_NAME}PatchProcess -DskipTests < /dev/null
 
@@ -797,7 +797,7 @@ checkFindbugsWarnings () {
     return 1
   fi
 
-  collectFindbugsReports patch $BASEDIR $PATCH_DIR 
+  collectFindbugsReports patch $BASEDIR $PATCH_DIR
   #this files are generated by collectFindbugsReports() named with its first argument
   patch_xml=$PATCH_DIR/patchFindbugsWarnings.xml
   trunk_xml=$PATCH_DIR/trunkFindbugsWarnings.xml
@@ -884,7 +884,7 @@ runTests () {
   if [[ $? != 0 ]] ; then
      ### Find and format names of failed tests
      failed_tests=`find . -name 'TEST*.xml' | xargs $GREP  -l -E "<failure|<error" | sed -e "s|.*target/surefire-reports/TEST-|                  |g" | sed -e "s|\.xml||g"`
- 
+
      JIRA_COMMENT="$JIRA_COMMENT
 
      {color:red}-1 core tests{color}.  The patch failed these unit tests:
@@ -962,7 +962,7 @@ checkInjectSystemFaults () {
   echo "======================================================================"
   echo ""
   echo ""
-  
+
   ### Kill any rogue build processes from the last attempt
   $PS auxwww | $GREP ${PROJECT_NAME}PatchProcess | $AWK '{print $2}' | /usr/bin/xargs -t -I {} /bin/kill -9 {} > /dev/null
 
@@ -1004,7 +1004,7 @@ $JIRA_COMMENT_FOOTER"
 
 
 
-$comment"  
+$comment"
 
   if [[ $JENKINS == "true" ]] ; then
     echo ""
@@ -1099,7 +1099,7 @@ checkLineLengths
 (( RESULT = RESULT + $? ))
 # checkSiteXml
 # (( RESULT = RESULT + $?))
-### Do not call these when run by a developer 
+### Do not call these when run by a developer
 if [[ $JENKINS == "true" ]] ; then
   runTests
   (( RESULT = RESULT + $? ))