-
Notifications
You must be signed in to change notification settings - Fork 16
Add Notice + License for binary #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@jbonofre: Please check this once. |
|
@ajantha-bhat thanks. I will. |
|
I'm resuming my review/work on this one. |
snazy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC we don't add LICENSE + NOTICE to the produced (non-bundle) jars as META-INF/LICENSE & META-INF/NOTICE. I think, that's not a problem unless we publish the individual artifacts to Maven Central.
From a brief look the LICENSE + NOTICE files look good, but I didn't cross check the whole files.
|
Looks like the |
|
rat error seems to be for This has not changed from this build. Probably it is flaky. |
Mind moving the |
Thanks for this suggestion. But the final CLI also uses the same logback and I don't want to have I also tried So, can we keep it as it is? |
Let's have an issue for this, so we don't forget. |
Add License and notice file for the CLI runtime jar (needed for the upcoming release)