Skip to content

Conversation

@ajantha-bhat
Copy link
Member

@ajantha-bhat ajantha-bhat commented Oct 23, 2025

Add License and notice file for the CLI runtime jar (needed for the upcoming release)

@ajantha-bhat ajantha-bhat changed the title Dep Clean up dependencies and add Notice and License Oct 23, 2025
@ajantha-bhat ajantha-bhat marked this pull request as draft October 23, 2025 07:42
@ajantha-bhat
Copy link
Member Author

@jbonofre: Please check this once.

@ajantha-bhat ajantha-bhat changed the title Clean up dependencies and add Notice and License Clean up dependencies and add Notice + License for binary Oct 23, 2025
@jbonofre
Copy link
Member

@ajantha-bhat thanks. I will.

@ajantha-bhat ajantha-bhat marked this pull request as ready for review October 28, 2025 05:17
@jbonofre
Copy link
Member

jbonofre commented Nov 3, 2025

I'm resuming my review/work on this one.

Copy link
Member

@snazy snazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC we don't add LICENSE + NOTICE to the produced (non-bundle) jars as META-INF/LICENSE & META-INF/NOTICE. I think, that's not a problem unless we publish the individual artifacts to Maven Central.

From a brief look the LICENSE + NOTICE files look good, but I didn't cross check the whole files.

@snazy
Copy link
Member

snazy commented Nov 4, 2025

Looks like the rat configuration needs some love (CI failure).

@ajantha-bhat
Copy link
Member Author

rat error seems to be for

Unapproved Licenses:
/Users/ajantha/Documents/workspace/polaris-tools/iceberg-catalog-migrator/cli/logs/catalog_migration.log
/Users/ajantha/Documents/workspace/polaris-tools/iceberg-catalog-migrator/api/logs/catalog_migration.log

This has not changed from this build. Probably it is flaky.
I fixed it by updating the rat config.

@ajantha-bhat ajantha-bhat changed the title Clean up dependencies and add Notice + License for binary Add Notice + License for binary Nov 6, 2025
@snazy
Copy link
Member

snazy commented Nov 9, 2025

rat error seems to be for

Unapproved Licenses:
/Users/ajantha/Documents/workspace/polaris-tools/iceberg-catalog-migrator/cli/logs/catalog_migration.log
/Users/ajantha/Documents/workspace/polaris-tools/iceberg-catalog-migrator/api/logs/catalog_migration.log

This has not changed from this build. Probably it is flaky. I fixed it by updating the rat config.

Mind moving the logs/ directory into the build/ folder? In a separate PR though.

@ajantha-bhat
Copy link
Member Author

Mind moving the logs/ directory into the build/ folder? In a separate PR though.

Thanks for this suggestion. But the final CLI also uses the same logback and I don't want to have build/logs folder for end user. For them logs is easy to find it.

I also tried console-log to use logs directory and root-log to use build/logs. So that CLI output will go to logs and normal output will go to build/logs. That didn't work. Everything is writing to build/logs.

So, can we keep it as it is?

@snazy
Copy link
Member

snazy commented Nov 10, 2025

So, can we keep it as it is?

Let's have an issue for this, so we don't forget.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants