Remove commons-collections:commons-collections references from sourcecode.

Replacing with org.apache.commons:commons-collections4. This ensures the outdated dependency is not used by pulsar code, but does not strip commons-collections from transitive dependencies. Initially aimed at addressing a CVE bundled with commons-collections, but does not clear commons-collections from the classpath.

Author: Zach Chuba

managed-ledger/src/test/java/org/apache/bookkeeper/mledger/impl/ManagedCursorTest.java

@@ -112,7 +112,7 @@
 import org.apache.bookkeeper.mledger.proto.MLDataFormats.PositionInfo;
 import org.apache.bookkeeper.mledger.util.ManagedLedgerUtils;
 import org.apache.bookkeeper.test.MockedBookKeeperTestCase;
-import org.apache.commons.collections.iterators.EmptyIterator;
+import org.apache.commons.collections4.iterators.EmptyIterator;
 import org.apache.commons.lang3.mutable.MutableBoolean;
 import org.apache.pulsar.common.api.proto.CommandSubscribe;
 import org.apache.pulsar.common.api.proto.IntRange;

pulsar-client-admin-shaded/pom.xml

@@ -128,7 +128,7 @@
                   <include>com.yahoo.datasketches:sketches-core</include>
                   <include>commons-*:*</include>
                   <include>commons-codec:commons-codec</include>
-                  <include>commons-collections:commons-collections</include>
+                  <include>org.apache.commons:commons-collections4</include>
                   <include>io.airlift:*</include>
                   <include>io.grpc:*</include>
                   <include>io.netty.incubator:*</include>

pulsar-client-all/pom.xml

@@ -171,7 +171,7 @@
                   <include>com.yahoo.datasketches:sketches-core</include>
                   <include>commons-*:*</include>
                   <include>commons-codec:commons-codec</include>
-                  <include>commons-collections:commons-collections</include>
+                  <include>org.apache.commons:commons-collections4</include>
                   <include>io.airlift:*</include>
                   <include>io.grpc:*</include>
                   <include>io.netty.incubator:*</include>

pulsar-client-shaded/pom.xml

@@ -145,7 +145,7 @@
                   <include>com.yahoo.datasketches:sketches-core</include>
                   <include>commons-*:*</include>
                   <include>commons-codec:commons-codec</include>
-                  <include>commons-collections:commons-collections</include>
+                  <include>org.apache.commons:commons-collections4</include>
                   <include>io.airlift:*</include>
                   <include>io.netty.incubator:*</include>
                   <include>io.netty:*</include>