[Improve][Core] Avoid relying on index alignment between keySet and values in `getSinkTables()`

[dybyte]

Search before asking

• I had searched in the feature and found no similar feature requirement.

Description

seatunnel/seatunnel-api/src/main/java/org/apache/seatunnel/api/sink/multitablesink/MultiTableSink.java

Lines 168 to 181 in e5fb01f

	public List<TablePath> getSinkTables() {
	List<TablePath> tablePaths = new ArrayList<>();
	List<SeaTunnelSink> values = new ArrayList<>(sinks.values());
	for (int i = 0; i < values.size(); i++) {
	if (values.get(i).getWriteCatalogTable().isPresent()) {
	tablePaths.add(
	((CatalogTable) values.get(i).getWriteCatalogTable().get()).getTablePath());
	} else {
	tablePaths.add(sinks.keySet().toArray(new TablePath[0])[i]);
	}
	}
	return tablePaths;
	}

It would be safer and clearer to iterate over entrySet() directly to ensure correct key-value association.

Usage Scenario

No response

Related issues

No response

Are you willing to submit a PR?

• Yes I am willing to submit a PR!

Code of Conduct

• I agree to follow this project's Code of Conduct

[dybyte]

cc @zooo-code

[zooo-code]

cc @zooo-code

Hi @dybyte,

Thanks for creating the issue!
I would love to work on this improvement.

Please assign it to me!

[DanielLeens]

Thanks for raising this improvement.

I checked the relevant path in MultiTableSink#getSinkTables() and the follow-up mapping in SinkFlowLifeCycle. The original implementation was relying on index-based alignment between the map-derived collections, which is not a good long-term shape even if it usually works on the normal path.

This has already been improved on the dev branch by PR #10665, which introduced an explicit mapping method and removed the index-based coupling in the sink flow logic. PR #10639 also added the related Javadocs earlier in the same area.

So from the current project state, this issue is already addressed and it is fine to keep it closed. Thanks again for spotting and driving this improvement, and thanks @zooo-code for the contribution.