Support flush statement SQL bind #36036
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strongduanmu
requested changes
Jul 21, 2025
| if (sqlStatement instanceof ExplainStatement) { | ||
| return new ExplainStatementContext(metaData, (ExplainStatement) sqlStatement, params, currentDatabaseName); | ||
| } | ||
| if (sqlStatement instanceof FlushStatement) { |
There was a problem hiding this comment.
Please use CommonSQLStatementContext.
| * Flush statement context. | ||
| */ | ||
| @Getter | ||
| public final class FlushStatementContext implements SQLStatementContext { |
There was a problem hiding this comment.
Maybe you can use CommonSQLStatementContext.
| if (tables.isEmpty()) { | ||
| return sqlStatement; | ||
| } | ||
|
|
There was a problem hiding this comment.
Please remove useless blank line.
| Collection<SimpleTableSegment> boundTables = tables.stream() | ||
| .map(each -> SimpleTableSegmentBinder.bind(each, binderContext, tableBinderContexts)) | ||
| .collect(Collectors.toList()); | ||
|
|
There was a problem hiding this comment.
Please remove useless blank line.
|
Hi @strongduanmu , I’ve made the updates, could u take a quick look at this PR? Thanks! |
strongduanmu
requested changes
Jul 29, 2025
| } | ||
|
|
||
| private FlushStatement copyFlushStatement(final FlushStatement sqlStatement, final Collection<SimpleTableSegment> tables) { | ||
| FlushStatement result = new FlushStatement(sqlStatement.getDatabaseType()) { |
There was a problem hiding this comment.
Hi @chakkk309, can you merge the latest branch. There is no FlushStatement now.
There was a problem hiding this comment.
I created FlushStatement in this pr, please have a check ~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #34029
Changes proposed in this pull request:
Before committing this PR, I'm sure that I have checked the following options:
./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.