Skip to content

Conversation

@Yikun
Copy link
Member

@Yikun Yikun commented Oct 11, 2022

What changes were proposed in this pull request?

This pach adds LICENSE and NOTICE:

Why are the changes needed?

https://www.apache.org/licenses/LICENSE-2.0#apply

See also: #2 (comment)

Does this PR introduce any user-facing change?

No

How was this patch tested?

No need

@Yikun
Copy link
Member Author

Yikun commented Oct 11, 2022

cc @tgravescs @HyukjinKwon

@Yikun
Copy link
Member Author

Yikun commented Oct 12, 2022

But its not clear to me how that applies to the binary generated from the docker file and what exactly needs to go into that docker file or in like. NOTICE-binary file. It would be good to ask Apache folks or see what other projects have done.

We (I and Tom) had some initial discuss in here: #2 (comment) , let me show more investigation here:

  • spark (Docekr Official Image, DOI):

  • apache/spark (Apache Spark Official image)

    • it published by Apache community
    • LEGAL-270: ASF allows dockerhub publish

      The main Docker Hub at hub.docker.com is a public-facing downstream distribution channel – similar to Maven Central, PyPI, Debian package management.

      Docker images can be built from our official source releases, but are derived distributions analogous to, say, Debian packages.

    • LEGAL-437: it might related to NOTICE-binary, but didn't get a clear results. However, according the ASF legal, leans to Any components in the parent container are the responsibility of the parent container (ie: owner of <image> in FROM <image>) to comply and generally trusting top level Linux OS images.
    • https://infra.apache.org/licensing-howto.html#binary there is nothing about Docker
    • Consider above two JIRAs and link, so I think NOTICE-binary will be same with apache/spark repo, or we can just reference https://github.com/apache/solr-docker, https://github.com/apache/flink-docker, only LICENSE and NOTICE is enough in here.

also cc @srowen (who created the LICENSE for apache/spark)

@HyukjinKwon
Copy link
Member

cc @srowen FYI

@tgravescs
Copy link

Ok, seems that plan is fine based on other projects. Its to bad they didn't answer all the questions on LEGAL-437.

@Yikun Yikun closed this in fc07aed Oct 13, 2022
@Yikun
Copy link
Member Author

Yikun commented Oct 13, 2022

@HyukjinKwon @srowen @tgravescs Thanks! Merged to master.

@HyukjinKwon
Copy link
Member

Thanks for driving this @Yikun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants