Skip to content

[Relax][Test] Cover default GPU pipeline scheduling for R.power/elementwise kernels#19923

Open
cchung100m wants to merge 2 commits into
apache:mainfrom
cchung100m:issue-19548
Open

[Relax][Test] Cover default GPU pipeline scheduling for R.power/elementwise kernels#19923
cchung100m wants to merge 2 commits into
apache:mainfrom
cchung100m:issue-19548

Conversation

@cchung100m

@cchung100m cchung100m commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Hi Commiters,

PR #19384 fixed routing in vm_build.py:249-265 but no regression test was added. This PR adds regression coverage for GPU scheduling of legalized elementwise ops for issue #19548.

Closes the test coverage gap:

  1. Device-Free Test: Verifies CUDA pipeline produces thread-bound kernels
  2. GPU-Test: end-to-end compile + execute, verify numerical correctness

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds unit tests to verify that the default CUDA pipeline correctly schedules and thread-binds an elementwise R.power kernel, preventing memory verification failures during compilation. The review feedback identifies two critical issues in the newly added tests: a syntax error on line 199 where the assignment operator = is missing (mod seq(PowerModule)), and a NameError on line 202 due to using an undefined tir name instead of tvm.tirx.PrimFunc.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread tests/python/relax/test_pipeline.py Outdated
Comment thread tests/python/relax/test_pipeline.py Outdated
@cchung100m cchung100m force-pushed the issue-19548 branch 4 times, most recently from 25581b9 to b102e9a Compare July 2, 2026 12:43
@cchung100m

Copy link
Copy Markdown
Contributor Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds tests to verify that the default CUDA pipeline correctly schedules and thread-binds an elementwise R.power kernel with a scalar constant operand, preventing VerifyMemory build failures. Feedback was provided to make the test assertion more robust by filtering for the specific "power" PrimFunc, avoiding potential failures if future legalization passes introduce host-side helper functions without thread bindings.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread tests/python/relax/test_pipeline.py Outdated
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@cchung100m cchung100m marked this pull request as ready for review July 5, 2026 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant