Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using CODEOWNERS to request reviews on content/security PR's? #152

Open
raboof opened this issue Sep 23, 2022 · 1 comment
Open

using CODEOWNERS to request reviews on content/security PR's? #152

raboof opened this issue Sep 23, 2022 · 1 comment

Comments

@raboof
Copy link
Member

raboof commented Sep 23, 2022

Hi! If I understand correctly, we'd generally like someone (maybe two?) from the security team to review PR's to files under content/security in the tree.

That's easy to miss. It looks like we could use a CODEOWNERS file to automatically request reviews from those people - how would you feel about trying that out?

@sebbASF
Copy link
Contributor

sebbASF commented Jun 17, 2023

Looks interesting.

Could also be used for files under content/legal.
And maybe content/licenses.

As long as the relevant people don't change too often, it should not be too hard to maintain the file.

Does the CODEOWNERS file need to require reviews?
Maybe it can protect itself? Can it accidentally become immutable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants