Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added og and twitter metadata #293

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

abhikrishnaram
Copy link

closes #268

I would like to test it on preview branch first

@rlenferink
Copy link
Member

rlenferink commented Aug 17, 2023

I just pushed this to the apache/preview/og-metadata branch to generate a preview.

After the build finishes, the result can be found at https://www-og-metadata.staged.apache.org/

<meta property="og:url" content="https://www.apache.org/">
<meta property="og:type" content="website">
<meta property="og:title" content="{{ page.title }}">
<meta property="og:description" content="Home page of The Apache Software Foundation">
Copy link
Member

@rlenferink rlenferink Aug 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This base.html is used as template for multiple pages besides the home page. Maybe this description can be made more generic (or using an auto generated page description maybe) ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added the support to give descriptions from individual pages just like title. I have also put a description in siteindex page in-order to test it. @rlenferink if you could update the branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preview and Generate Open Graph Meta Tags
2 participants