apply review

Author: dididy

zeppelin-web-angular/e2e/models/node-list-page.ts

@@ -51,11 +51,11 @@ export class NodeListPage extends BasePage {
     await this.filterInput.clear();
   }
 
-  async getFolderByName(folderName: string): Locator {
+  getFolderByName(folderName: string): Locator {
     return this.page.locator('nz-tree-node').filter({ hasText: folderName }).first();
   }
 
-  async getNoteByName(noteName: string): Locator {
+  getNoteByName(noteName: string): Locator {
     return this.page.locator('nz-tree-node').filter({ hasText: noteName }).first();
   }
 

zeppelin-web-angular/e2e/tests/share/note-create/note-create-modal.spec.ts

@@ -55,6 +55,16 @@ test.describe('Note Create Modal', () => {
 
     await page.waitForURL(/notebook\//);
     expect(page.url()).toContain('notebook/');
+
+    // Verify the note was created with the correct name
+    const notebookTitle = page.locator('.notebook-title, .note-title, h1, [data-testid="notebook-title"]');
+    await expect(notebookTitle).toContainText(uniqueName);
+
+    // Verify in the navigation tree if available
+    await page.goto('/');
+    await page.waitForLoadState('networkidle');
+    const noteInTree = page.locator(`a:has-text("${uniqueName}")`);
+    await expect(noteInTree).toBeVisible();
   });
 
   test('Given Create Note modal is open, When entering note name with folder path, Then note should be created in folder', async ({
@@ -69,6 +79,29 @@ test.describe('Note Create Modal', () => {
 
     await page.waitForURL(/notebook\//);
     expect(page.url()).toContain('notebook/');
+
+    // Verify the note was created with the correct name (without folder path)
+    const notebookTitle = page.locator('.notebook-title, .note-title, h1, [data-testid="notebook-title"]');
+    await expect(notebookTitle).toContainText(noteName);
+
+    // Verify the note appears in the correct folder structure
+    await page.goto('/');
+    await page.waitForLoadState('networkidle');
+
+    // Navigate through folder structure to find the note
+    // Look for TestFolder
+    const testFolder = page.locator('.folder-name, .tree-node').filter({ hasText: 'TestFolder' }).first();
+    await expect(testFolder).toBeVisible();
+    await testFolder.click();
+
+    // Look for SubFolder
+    const subFolder = page.locator('.folder-name, .tree-node').filter({ hasText: 'SubFolder' }).first();
+    await expect(subFolder).toBeVisible();
+    await subFolder.click();
+
+    // Verify the note exists in the subfolder
+    const noteInSubFolder = page.locator(`a:has-text("${noteName}")`);
+    await expect(noteInSubFolder).toBeVisible();
   });
 
   test('Given Create Note modal is open, When clicking close button, Then modal should close', async () => {

zeppelin-web-angular/e2e/tests/share/note-import/note-import-modal.spec.ts

@@ -102,10 +102,8 @@ test.describe('Note Import Modal', () => {
 
     await page.waitForTimeout(2000);
 
-    const hasError = await noteImportModal.isErrorAlertVisible();
-    if (hasError) {
-      const errorMessage = await noteImportModal.getErrorMessage();
-      expect(errorMessage).toBeTruthy();
-    }
+    await noteImportModal.isErrorAlertVisible();
+    const errorMessage = await noteImportModal.getErrorMessage();
+    expect(errorMessage).toBeTruthy();
   });
 });