Skip to content

Commit ab09089

Browse files
dididydididy
committed
apply lint:fix
1 parent 8f9cb78 commit ab09089

File tree

6 files changed

+17
-79
lines changed

6 files changed

+17
-79
lines changed

‎zeppelin-web-angular/e2e/models/notebook-sidebar-page.ts‎

Lines changed: 6 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -60,17 +60,9 @@ export class NotebookSidebarPage extends BasePage {
6060
// Strategy 1: Original button selector
6161
() => this.tocButton.click(),
6262
// Strategy 2: Look for unordered-list icon specifically in sidebar
63-
() =>
64-
this.page
65-
.locator('zeppelin-notebook-sidebar i[nzType="unordered-list"]')
66-
.first()
67-
.click(),
63+
() => this.page.locator('zeppelin-notebook-sidebar i[nzType="unordered-list"]').first().click(),
6864
// Strategy 3: Look for any button with list-related icons
69-
() =>
70-
this.page
71-
.locator('zeppelin-notebook-sidebar button:has(i[nzType="unordered-list"])')
72-
.first()
73-
.click(),
65+
() => this.page.locator('zeppelin-notebook-sidebar button:has(i[nzType="unordered-list"])').first().click(),
7466
// Strategy 4: Try aria-label or title containing "table" or "content"
7567
() =>
7668
this.page
@@ -177,31 +169,16 @@ export class NotebookSidebarPage extends BasePage {
177169
// Strategy 1: Original close button selector
178170
() => this.closeButton.click(),
179171
// Strategy 2: Look for close icon specifically in sidebar
180-
() =>
181-
this.page
182-
.locator('zeppelin-notebook-sidebar i[nzType="close"]')
183-
.first()
184-
.click(),
172+
() => this.page.locator('zeppelin-notebook-sidebar i[nzType="close"]').first().click(),
185173
// Strategy 3: Look for any button with close-related icons
186-
() =>
187-
this.page
188-
.locator('zeppelin-notebook-sidebar button:has(i[nzType="close"])')
189-
.first()
190-
.click(),
174+
() => this.page.locator('zeppelin-notebook-sidebar button:has(i[nzType="close"])').first().click(),
191175
// Strategy 4: Try any close-related elements
192176
() =>
193-
this.page
194-
.locator('zeppelin-notebook-sidebar .close, zeppelin-notebook-sidebar .sidebar-close')
195-
.first()
196-
.click(),
177+
this.page.locator('zeppelin-notebook-sidebar .close, zeppelin-notebook-sidebar .sidebar-close').first().click(),
197178
// Strategy 5: Try keyboard shortcut (Escape key)
198179
() => this.page.keyboard.press('Escape'),
199180
// Strategy 6: Click on the sidebar toggle button again (might close it)
200-
() =>
201-
this.page
202-
.locator('zeppelin-notebook-sidebar button')
203-
.first()
204-
.click()
181+
() => this.page.locator('zeppelin-notebook-sidebar button').first().click()
205182
];
206183

207184
let success = false;

‎zeppelin-web-angular/e2e/models/notebook-sidebar-page.util.ts‎

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -295,15 +295,12 @@ export class NotebookSidebarUtil {
295295
const url = this.page.url();
296296
const noteIdMatch = url.match(/\/notebook\/([^\/\?]+)/);
297297
if (!noteIdMatch) {
298-
throw new Error('Failed to extract notebook ID from URL: ' + url);
298+
throw new Error(`Failed to extract notebook ID from URL: ${url}`);
299299
}
300300
const noteId = noteIdMatch[1];
301301

302302
// Get first paragraph ID with increased timeout
303-
await this.page
304-
.locator('zeppelin-notebook-paragraph')
305-
.first()
306-
.waitFor({ state: 'visible', timeout: 20000 });
303+
await this.page.locator('zeppelin-notebook-paragraph').first().waitFor({ state: 'visible', timeout: 20000 });
307304
const paragraphContainer = this.page.locator('zeppelin-notebook-paragraph').first();
308305

309306
// Try to get paragraph ID from the paragraph element's data-testid attribute

‎zeppelin-web-angular/e2e/tests/workspace/notebook-repos/notebook-repo-item-edit.spec.ts‎

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -73,11 +73,7 @@ test.describe('Notebook Repository Item - Edit Mode', () => {
7373
}
7474

7575
const firstRow = repoItemPage.settingRows.first();
76-
const settingName =
77-
(await firstRow
78-
.locator('td')
79-
.first()
80-
.textContent()) || '';
76+
const settingName = (await firstRow.locator('td').first().textContent()) || '';
8177
const originalValue = await repoItemPage.getSettingValue(settingName);
8278

8379
await repoItemPage.clickEdit();

‎zeppelin-web-angular/e2e/tests/workspace/notebook-repos/notebook-repo-item-form-validation.spec.ts‎

Lines changed: 3 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -46,11 +46,7 @@ test.describe('Notebook Repository Item - Form Validation', () => {
4646
await repoItemPage.clickEdit();
4747

4848
const firstRow = repoItemPage.settingRows.first();
49-
const settingName =
50-
(await firstRow
51-
.locator('td')
52-
.first()
53-
.textContent()) || '';
49+
const settingName = (await firstRow.locator('td').first().textContent()) || '';
5450

5551
const isInputVisible = await repoItemPage.isInputVisible(settingName);
5652
if (isInputVisible) {
@@ -73,11 +69,7 @@ test.describe('Notebook Repository Item - Form Validation', () => {
7369
await repoItemPage.clickEdit();
7470

7571
const firstRow = repoItemPage.settingRows.first();
76-
const settingName =
77-
(await firstRow
78-
.locator('td')
79-
.first()
80-
.textContent()) || '';
72+
const settingName = (await firstRow.locator('td').first().textContent()) || '';
8173

8274
const isInputVisible = await repoItemPage.isInputVisible(settingName);
8375
if (isInputVisible) {
@@ -102,11 +94,7 @@ test.describe('Notebook Repository Item - Form Validation', () => {
10294

10395
for (let i = 0; i < settingRows; i++) {
10496
const row = repoItemPage.settingRows.nth(i);
105-
const settingName =
106-
(await row
107-
.locator('td')
108-
.first()
109-
.textContent()) || '';
97+
const settingName = (await row.locator('td').first().textContent()) || '';
11098

11199
const isInputVisible = await repoItemPage.isInputVisible(settingName);
112100
if (isInputVisible) {

‎zeppelin-web-angular/e2e/tests/workspace/notebook-repos/notebook-repo-item-settings.spec.ts‎

Lines changed: 3 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -60,11 +60,7 @@ test.describe('Notebook Repository Item - Settings', () => {
6060

6161
for (let i = 0; i < settingRows; i++) {
6262
const row = repoItemPage.settingRows.nth(i);
63-
const settingName =
64-
(await row
65-
.locator('td')
66-
.first()
67-
.textContent()) || '';
63+
const settingName = (await row.locator('td').first().textContent()) || '';
6864

6965
const isInputVisible = await repoItemPage.isInputVisible(settingName);
7066
if (isInputVisible) {
@@ -86,11 +82,7 @@ test.describe('Notebook Repository Item - Settings', () => {
8682

8783
for (let i = 0; i < settingRows; i++) {
8884
const row = repoItemPage.settingRows.nth(i);
89-
const settingName =
90-
(await row
91-
.locator('td')
92-
.first()
93-
.textContent()) || '';
85+
const settingName = (await row.locator('td').first().textContent()) || '';
9486

9587
const isDropdownVisible = await repoItemPage.isDropdownVisible(settingName);
9688
if (isDropdownVisible) {
@@ -112,11 +104,7 @@ test.describe('Notebook Repository Item - Settings', () => {
112104
let foundInput = false;
113105
for (let i = 0; i < settingRows; i++) {
114106
const row = repoItemPage.settingRows.nth(i);
115-
const settingName =
116-
(await row
117-
.locator('td')
118-
.first()
119-
.textContent()) || '';
107+
const settingName = (await row.locator('td').first().textContent()) || '';
120108

121109
const isInputVisible = await repoItemPage.isInputVisible(settingName);
122110
if (isInputVisible) {

‎zeppelin-web-angular/e2e/tests/workspace/notebook-repos/notebook-repo-item-workflow.spec.ts‎

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -51,11 +51,7 @@ test.describe('Notebook Repository Item - Edit Workflow', () => {
5151
let foundSetting = false;
5252
for (let i = 0; i < settingRows; i++) {
5353
const row = repoItemPage.settingRows.nth(i);
54-
const settingName =
55-
(await row
56-
.locator('td')
57-
.first()
58-
.textContent()) || '';
54+
const settingName = (await row.locator('td').first().textContent()) || '';
5955

6056
const isInputVisible = await repoItemPage.isInputVisible(settingName);
6157
if (isInputVisible) {
@@ -91,11 +87,7 @@ test.describe('Notebook Repository Item - Edit Workflow', () => {
9187
await repoItemUtil.verifyDisplayMode();
9288

9389
const firstRow = repoItemPage.settingRows.first();
94-
const settingName =
95-
(await firstRow
96-
.locator('td')
97-
.first()
98-
.textContent()) || '';
90+
const settingName = (await firstRow.locator('td').first().textContent()) || '';
9991
const originalValue = await repoItemPage.getSettingValue(settingName);
10092

10193
await repoItemPage.clickEdit();

0 commit comments

Comments
 (0)