[ZEPPELIN-6373] Add E2E tests about share area #5114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dididy
force-pushed
the
e2e/share
branch
6 times, most recently
from
ece19b8 to
8684e2c
Compare
tbonelee
requested changes
Nov 7, 2025
Contributor
tbonelee
left a comment
tbonelee
left a comment
There was a problem hiding this comment.
Thanks for the PR! Test scenarios look good and are clear.
I've also added several commits that remove unused codes. If they make sense to you, please feel free to incorporate them.
https://github.com/tbonelee/zeppelin/commits/PR_5114-refactor/
Thanks!
Comment on lines
49
to
92
| test('Given Create Note modal is open, When entering custom note name and creating, Then new note should be created successfully', async ({ | ||
| page | ||
| }) => { | ||
| const uniqueName = `Test Note ${Date.now()}`; | ||
| await noteCreateModal.setNoteName(uniqueName); | ||
| await noteCreateModal.clickCreate(); | ||
|
|
||
| await page.waitForURL(/notebook\//); | ||
| expect(page.url()).toContain('notebook/'); | ||
| }); | ||
|
|
||
| test('Given Create Note modal is open, When entering note name with folder path, Then note should be created in folder', async ({ | ||
| page | ||
| }) => { | ||
| const folderPath = `/TestFolder/SubFolder`; | ||
| const noteName = `Note ${Date.now()}`; | ||
| const fullPath = `${folderPath}/${noteName}`; | ||
|
|
||
| await noteCreateModal.setNoteName(fullPath); | ||
| await noteCreateModal.clickCreate(); | ||
|
|
||
| await page.waitForURL(/notebook\//); | ||
| expect(page.url()).toContain('notebook/'); | ||
| }); |
Contributor
There was a problem hiding this comment.
It would be better if we could verify the note name and path.
Comment on lines
105
to
109
| const hasError = await noteImportModal.isErrorAlertVisible(); | ||
| if (hasError) { | ||
| const errorMessage = await noteImportModal.getErrorMessage(); | ||
| expect(errorMessage).toBeTruthy(); | ||
| } |
Contributor
There was a problem hiding this comment.
Is there any reason for this to be verified conditionally?
dididy
force-pushed
the
e2e/share
branch
2 times, most recently
from
b6dbb72 to
1a1cd06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
ABOUT_ZEPPELIN:'src/app/share/about-zeppelin/about-zeppelin.component',
CODE_EDITOR:'src/app/share/code-editor/code-editor.component',
FOLDER_RENAME:'src/app/share/folder-rename/folder-rename.component',
HEADER:'src/app/share/header/header.component',
NODE_LIST:'src/app/share/node-list/node-list.component',
NOTE_CREATE:'src/app/share/note-create/note-create.component',
NOTE_IMPORT:'src/app/share/note-import/note-import.component',
NOTE_RENAME:'src/app/share/note-rename/note-rename.component',
NOTE_TOC:'src/app/share/note-toc/note-toc.component',
PAGE_HEADER:'src/app/share/page-header/page-header.component',
RESIZE_HANDLE:'src/app/share/resize-handle/resize-handle.component',
SHORTCUT:'src/app/share/shortcut/shortcut.component',
SPIN:'src/app/share/spin/spin.component',
THEME_TOGGLE:'src/app/share/theme-toggle/theme-toggle.component'
What type of PR is it?
Improvement
Please leave your type of PR only
Todos
What is the Jira issue?
ZEPPELIN-6373
How should this be tested?
Screenshots (if appropriate)
Questions: