Skip to content

Commit 7136f9b

Browse files
committed
Merge from master and remove skiping of curl tests
1 parent 7bab347 commit 7136f9b

File tree

2 files changed

+0
-9
lines changed

2 files changed

+0
-9
lines changed

tests/unit/_utils/test_sitemap.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,7 @@
11
import base64
22
import gzip
3-
import sys
43
from datetime import datetime
54

6-
import pytest
75
from yarl import URL
86

97
from crawlee._utils.sitemap import Sitemap, SitemapUrl, parse_sitemap
@@ -95,8 +93,6 @@ async def test_gzipped_sitemap(server_url: URL, http_client: HttpClient) -> None
9593
assert set(sitemap.urls) == BASIC_RESULTS
9694

9795

98-
# TODO: Remove this skip when #1460 is resolved.
99-
@pytest.mark.skipif(sys.platform != 'linux', reason='Flaky with Curl on Windows, see #1460.')
10096
async def test_gzipped_sitemap_with_invalid_data(server_url: URL, http_client: HttpClient) -> None:
10197
"""Test loading a invalid gzipped sitemap with correct type and .xml.gz url."""
10298
compress_data = compress_gzip(BASIC_SITEMAP)

tests/unit/http_clients/test_http_clients.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
from __future__ import annotations
22

33
import os
4-
import sys
54
from typing import TYPE_CHECKING
65

76
import pytest
@@ -164,10 +163,6 @@ async def test_send_request_allow_redirects_false(custom_http_client: HttpClient
164163

165164

166165
async def test_stream(http_client: HttpClient, server_url: URL) -> None:
167-
# TODO: Remove this skip when #1494 is resolved.
168-
if isinstance(http_client, CurlImpersonateHttpClient) and sys.platform != 'linux':
169-
pytest.skip('Flaky with Curl on Windows, see #1494.')
170-
171166
content_body: bytes = b''
172167

173168
async with http_client.stream(str(server_url)) as response:

0 commit comments

Comments
 (0)