Fix 392 (#393)

* fix: don't add a instance if there's no image

* chore: re-record test mock data

* chore(lint): fix lint errors

Author: Kristján Oddsson

endpoints/cinema/index.js

@@ -59,29 +59,27 @@ app.get('/cinema', (req, res) => {
         showtimes.push(theater)
       })
 
-      const urls = movie
-        .find('img')
-        .attr('src')
-        .match(/\/images\/poster\/.+\.(jpg|jpeg|png)/ig) || []
-
-      const imgUrl = `http://kvikmyndir.is${urls[0]}`
-
-      const realeasedYear = movie
-        .find('.mynd_titill_artal')
-        .text()
-        .replace('/[()]/g', '')
-
-      // Create an object of info
-      // and add it to the 'results' array.
-      obj.results.push({
-        title: movie.find('.title').remove('.year').html().trim(),
-        released: realeasedYear,
-        restricted: null,
-        imdb: movie.find('.imdbEinkunn').text().trim(),
-        imdbLink: movie.find('.imdbEinkunn a').attr('href') ? movie.find('.imdbEinkunn a').attr('href').trim() : '',
-        image: imgUrl,
-        showtimes,
-      })
+      const src = movie.find('img').attr('src')
+      if (src) {
+        const urls = src.match(/\/images\/poster\/.+\.(jpg|jpeg|png)/ig) || []
+        const imgUrl = `http://kvikmyndir.is${urls[0]}`
+        const realeasedYear = movie
+          .find('.mynd_titill_artal')
+          .text()
+          .replace('/[()]/g', '')
+
+        // Create an object of info
+        // and add it to the 'results' array.
+        obj.results.push({
+          title: movie.find('.title').remove('.year').html().trim(),
+          released: realeasedYear,
+          restricted: null,
+          imdb: movie.find('.imdbEinkunn').text().trim(),
+          imdbLink: movie.find('.imdbEinkunn a').attr('href') ? movie.find('.imdbEinkunn a').attr('href').trim() : '',
+          image: imgUrl,
+          showtimes,
+        })
+      }
     })
 
     return res.cache().json(obj)

endpoints/cinema/tests/integration_test.js

@@ -1,2 +1,12 @@
-describe('cinema', () => { })
+const request = require('request')
+const helpers = require('../../../lib/test_helpers')
+
+describe('/cinema', () => {
+  it('should return an array of objects containing correct fields', (done) => {
+    const fieldsToCheckFor = ['title', 'released', 'restricted', 'imdb', 'imdbLink', 'image', 'showtimes']
+    const params = helpers.testRequestParams('/cinema')
+    const resultHandler = helpers.testRequestHandlerForFields(done, fieldsToCheckFor)
+    request.get(params, resultHandler)
+  })
+})
 describe('cinema theaters', () => { })