v3 apollo-server-lambda missing {event} in context function?

[cluedtke]

I upgraded:

• apollo-server-lambda: 2.25.2 -> 3.0.0
• apollo-server-types: 0.9.0 -> 3.0.0

v3.0.0 CHANGELOG indicates:

Also, the context function now receives an express: { req, res } option in addition to event and context

However, after upgrading, the event field gone missing and I cannot figure out how to get it back:

Anyone else run into this? I think it's a types issue.

Edit: context also gone missing.

[glasser]

Ah, I see what's happening here. I think this does work at the JS level but not at the TS level.

The base ApolloServer class from apollo-server-core declares that its context function takes a loosely typed argument (any). The ApolloServer class in apollo-server-express overrides the constructor just to note that its context function takes a well-typed argument (and apollo-server which is built on apollo-server-express uses the same typing). The other random integrations keep the loosely typed base declaration.

However, starting with Apollo Server 3, apollo-server-lambda (and apollo-server-cloud-functions) inherit from apollo-server-express, so they get the Express constructor's typing, which isn't correct.

I think we can fix this though! Lemme give it a quick shot.

[glasser]

Created #5480

[glasser]

#5481

[cluedtke]

Thanks for the attention. You're fast! I subscribed to the issue and PR and will keep an eye on them.

[glasser]

Fix released in 3.0.1. Let me know if it works better for you now!

[cluedtke]

Works better in 3.0.1, that did the trick. Thanks again!