Skip to content

Commit 9590c55

Browse files
dlambrigDan Lambright
andauthored
Track temp tag message counts in TLogMetrics (#12460)
Co-authored-by: Dan Lambright <[email protected]>
1 parent 776ceb0 commit 9590c55

File tree

1 file changed

+12
-10
lines changed

1 file changed

+12
-10
lines changed

fdbserver/TLogServer.actor.cpp

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -567,6 +567,7 @@ struct LogData : NonCopyable, public ReferenceCounted<LogData> {
567567

568568
CounterCollection cc;
569569
Counter bytesInput;
570+
Counter tempTagMessageCount;
570571
Counter bytesDurable;
571572
Counter blockingPeeks;
572573
Counter blockingPeekTimeouts;
@@ -664,16 +665,16 @@ struct LogData : NonCopyable, public ReferenceCounted<LogData> {
664665
: initialized(false), queueCommittingVersion(0), knownCommittedVersion(0), durableKnownCommittedVersion(0),
665666
minKnownCommittedVersion(0), queuePoppedVersion(0), minPoppedTagVersion(0), minPoppedTag(invalidTag),
666667
unpoppedRecoveredTagCount(0), cc("TLog", interf.id().toString()), bytesInput("BytesInput", cc),
667-
bytesDurable("BytesDurable", cc), blockingPeeks("BlockingPeeks", cc),
668-
blockingPeekTimeouts("BlockingPeekTimeouts", cc), emptyPeeks("EmptyPeeks", cc),
669-
nonEmptyPeeks("NonEmptyPeeks", cc), persistentDataUpdateBatches("PersistentDataUpdateBatches", cc),
670-
dirtyTagsProcessed("DirtyTagsProcessed", cc), logId(interf.id()), protocolVersion(protocolVersion),
671-
newPersistentDataVersion(invalidVersion), tLogData(tLogData), unrecoveredBefore(1), recoveredAt(1),
672-
recoveryTxnVersion(1), logSystem(new AsyncVar<Reference<ILogSystem>>()), remoteTag(remoteTag),
673-
isPrimary(isPrimary), logRouterTags(logRouterTags), logRouterPoppedVersion(0), logRouterPopToVersion(0),
674-
locality(tagLocalityInvalid), recruitmentID(recruitmentID), logSpillType(logSpillType),
675-
allTags(tags.begin(), tags.end()), terminated(tLogData->terminated.getFuture()), execOpCommitInProgress(false),
676-
txsTags(txsTags) {
668+
tempTagMessageCount("TempTagMessageCount", cc), bytesDurable("BytesDurable", cc),
669+
blockingPeeks("BlockingPeeks", cc), blockingPeekTimeouts("BlockingPeekTimeouts", cc),
670+
emptyPeeks("EmptyPeeks", cc), nonEmptyPeeks("NonEmptyPeeks", cc),
671+
persistentDataUpdateBatches("PersistentDataUpdateBatches", cc), dirtyTagsProcessed("DirtyTagsProcessed", cc),
672+
logId(interf.id()), protocolVersion(protocolVersion), newPersistentDataVersion(invalidVersion),
673+
tLogData(tLogData), unrecoveredBefore(1), recoveredAt(1), recoveryTxnVersion(1),
674+
logSystem(new AsyncVar<Reference<ILogSystem>>()), remoteTag(remoteTag), isPrimary(isPrimary),
675+
logRouterTags(logRouterTags), logRouterPoppedVersion(0), logRouterPopToVersion(0), locality(tagLocalityInvalid),
676+
recruitmentID(recruitmentID), logSpillType(logSpillType), allTags(tags.begin(), tags.end()),
677+
terminated(tLogData->terminated.getFuture()), execOpCommitInProgress(false), txsTags(txsTags) {
677678
startRole(Role::TRANSACTION_LOG,
678679
interf.id(),
679680
tLogData->workerID,
@@ -1532,6 +1533,7 @@ void commitMessages(TLogData* self,
15321533
if (!taggedMessages.size()) {
15331534
return;
15341535
}
1536+
logData->tempTagMessageCount += taggedMessages.size();
15351537

15361538
int msgSize = 0;
15371539
for (auto& i : taggedMessages) {

0 commit comments

Comments
 (0)